Code review comment for lp:~oif-team/evemu/fix-evbit-handling

Revision history for this message
Henrik Rydberg (rydberg) wrote :

Documentation should be enough. Right now, there are at least two ways to interpret the letter "B:" one is that it means something with bitmask, and the numbers correspond to something. There is nothing documented saying all B:s have to means the same thing, and indeed, they don't. Thus, a change of letters only switches confusion to some other place.

The main reason to not change this is not technical, but a matter of stability. The file format is already in use. This alone makes a request like this branch raise all red flags. When combined with the fact that indeed, the whole issue is just a matter of interpretation, it makes it even more important to say no.

I am disapproving this again, to underline that fact that I really, really, think this is both a silly and harmful change.

review: Disapprove

« Back to merge proposal