Merge lp:~ogra/ubuntu-touch-session/fix-oom-score-1377869 into lp:ubuntu-touch-session

Proposed by Oliver Grawert
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 231
Merged at revision: 231
Proposed branch: lp:~ogra/ubuntu-touch-session/fix-oom-score-1377869
Merge into: lp:ubuntu-touch-session
Diff against target: 10 lines (+1/-1)
1 file modified
lightdm.override (+1/-1)
To merge this branch: bzr merge lp:~ogra/ubuntu-touch-session/fix-oom-score-1377869
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Review via email: mp+237242@code.launchpad.net

Commit message

fix the oom score for the ubuntu-touch session so that the value lies above system processes and session processes get killed first.

Description of the change

fix the oom score for the ubuntu-touch session so that the value lies above system processes and session processes get killed first.

To post a comment you must log in.
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

doesn't this affect lightdm itself too?

review: Needs Information
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

[09:32:35] <sergiusens> ogra: if you kill lightdm, what is the difference? isn't just moving the bug somewhere else?
[09:32:56] <sergiusens> isn't this change*...
[09:33:12] <ogra> sergiusens, but since cwayne added all these scopes who are not lifecycle managed at all, we now have higher memory pressure ...
[09:33:38] <ogra> the wrong value in the lightdm job causes system processes to be killed *before* any session processes are
[09:34:10] <ogra> lightdm is surely on the edge here ... first of all we want that dbus, powerd and firends survive though
[09:34:59] <ogra> sergiusens, btw, this was discussed all morning already ... the value change is right
[09:35:04] <ogra> also see http://paste.ubuntu.com/8505997/
[09:35:19] <ogra> all session stuff needs to be above 0
[09:35:35] <ogra> (container stuff has -941 by default ... systtem stuff has 0
[09:35:37] <ogra> )

[09:37:22] <sergiusens> ogra: I would still consider this a work around fix
[09:37:38] <ogra> lifecycle mgmt bases on the value set by lightdm and adds/subtracts from that
[09:37:59] <ogra> sergiusens, well, we wont re-design the session management now ... :)
[09:38:17] <ogra> i agree that setting it in lightdm is wrong ... but we have done that since we started ...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lightdm.override'
2--- lightdm.override 2014-06-30 16:34:17 +0000
3+++ lightdm.override 2014-10-06 11:34:20 +0000
4@@ -1,5 +1,5 @@
5 limit nice 40 40
6-oom score -10
7+oom score 10
8
9 # lightdm job normally waits for plymouth-ready, but since we disable plymouth,
10 # we remove that condition from lightdm's start stanza

Subscribers

People subscribed via source and target branches