Merge ~ogra/snappy-hwe-snaps/+git/pulseaudio:master into ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master
| Status: | Merged |
|---|---|
| Approved by: | Simon Fels on 2017-11-07 |
| Approved revision: | d5022d2f9d646f50242a844bd99d78627b2ebfb3 |
| Merged at revision: | 2f055c68e835de107fe653d42e3b0533e48df946 |
| Proposed branch: | ~ogra/snappy-hwe-snaps/+git/pulseaudio:master |
| Merge into: | ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master |
| Diff against target: |
40 lines (+1/-3) 2 files modified
bin/pulseaudio (+0/-1) snapcraft.yaml (+1/-2) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Simon Fels | Approve on 2017-11-07 | ||
| System Enablement Bot | continuous-integration | Approve on 2017-11-06 | |
| Jim Hodapp (community) | 2017-11-03 | Approve on 2017-11-03 | |
|
Review via email:
|
|||
Commit message
Enable BlueZ 5 support.
Enable compiling modules for Bluetooth support. This change also removes
the disallow-
module-
Description of the change
Enable compiling modules for Bluetooth support. This change also removes
the disallow-
module-
PASSED: Successfully build documentation, rev: d5022d2f9d646f5
Generated documentation is available at https:/
FAILED: Continuous integration, rev:d5022d2f9d6
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Successfully build documentation, rev: d5022d2f9d646f5
Generated documentation is available at https:/
PASSED: Continuous integration, rev:d5022d2f9d6
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
None: https:/
Click here to trigger a rebuild:
https:/
| Simon Fels (morphis) wrote : | # |
LGTM, did you give this a manual test run on a device as our CI testing is not working atm?
| Oliver Grawert (ogra) wrote : | # |
loks like it finished fine in CI, but yes, i did do a test build
| Simon Fels (morphis) wrote : | # |
Yeah the build in CI finished but I've disabled test execution.
On Mon, Nov 6, 2017 at 10:16 AM, Oliver Grawert <email address hidden> wrote:
> loks like it finished fine in CI, but yes, i did do a test build
> --
> https:/
> pulseaudio/
> Your team Snappy HWE Team is subscribed to branch
> ~snappy-
>
> Launchpad-
> Launchpad-
> Launchpad-
> Launchpad-Branch: ~snappy-
> Launchpad-Project: snappy-hwe-snaps
>
LGTM