Merge ~ogra/snappy-hwe-snaps/+git/pulseaudio:master into ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master

[Oliver Grawert]

Enable BlueZ 5 support.

Enable compiling modules for Bluetooth support. This change also removes
the disallow-module-loading flag because pulseaudio needs to load
module-bluez5-device after a device connects.

Enable compiling modules for Bluetooth support. This change also removes
the disallow-module-loading flag because pulseaudio needs to load
module-bluez5-device after a device connects.

[Jim Hodapp (jhodapp)]

LGTM

review: Approve

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Successfully build documentation, rev: d5022d2f9d646f50242a844bd99d78627b2ebfb3

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/896/

[System Enablement Bot (system-enablement-ci-bot)]

FAILED: Continuous integration, rev:d5022d2f9d646f50242a844bd99d78627b2ebfb3
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/52/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/102/console
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/102/console
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/102/console
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/102/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/896
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/643
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/663/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/52/rebuild

review: Needs Fixing (continuous-integration)

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Successfully build documentation, rev: d5022d2f9d646f50242a844bd99d78627b2ebfb3

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/899/

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Continuous integration, rev:d5022d2f9d646f50242a844bd99d78627b2ebfb3
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/53/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/103
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/103
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/103
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/103
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/899
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/646
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/666/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/53/rebuild

review: Approve (continuous-integration)

[Simon Fels (morphis)]

LGTM, did you give this a manual test run on a device as our CI testing is not working atm?

[Oliver Grawert (ogra)]

loks like it finished fine in CI, but yes, i did do a test build

[Simon Fels (morphis)]

Yeah the build in CI finished but I've disabled test execution.

On Mon, Nov 6, 2017 at 10:16 AM, Oliver Grawert <email address hidden> wrote:

> loks like it finished fine in CI, but yes, i did do a test build
> --
> https://code.launchpad.net/~ogra/snappy-hwe-snaps/+git/
> pulseaudio/+merge/333211
> Your team Snappy HWE Team is subscribed to branch
> ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master.
>
> Launchpad-Message-Rationale: Subscriber @snappy-hwe-team
> Launchpad-Message-For: snappy-hwe-team
> Launchpad-Notification-Type: code-review
> Launchpad-Branch: ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master
> Launchpad-Project: snappy-hwe-snaps
>

[Simon Fels (morphis)]

LGTM

review: Approve

diff --git a/bin/pulseaudio b/bin/pulseaudio
index fa1c474..8b9a797 100755
--- a/bin/pulseaudio
+++ b/bin/pulseaudio
@@ -22,7 +22,6 @@ fi
 exec $SNAP/usr/bin/pulseaudio \
     --exit-idle-time=-1 \
     --disallow-exit=yes \
-    --disallow-module-loading \
     --system \
     -F $SNAP/etc/pulse/default.pa \
     -p $SNAP/usr/lib/pulse-8.0/modules \
diff --git a/snapcraft.yaml b/snapcraft.yaml
index 736791d..b4bf686 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -109,6 +109,7 @@ parts:
       - libudev-dev
       - libasyncns-dev
       - libxcb1-dev
+      - libsbc-dev
 
     configflags:
       - --prefix=/usr
@@ -121,7 +122,6 @@ parts:
       - --disable-orc
       - --disable-gconf
       - --disable-bluez4
-      - --disable-bluez5
       - --disable-esound
       - --disable-adrian-aec
       - --disable-gtk3
@@ -129,7 +129,6 @@ parts:
       - --disable-systemd-login
       - --without-caps
       - --disable-webrtc-aec
-      - --disable-dbus
       - --disable-oss-output
       - --disable-oss-wrapper
       - --disable-jack