Merge lp:~ogra/phablet-tools/phablet-tools-fix-edge-intro into lp:phablet-tools

Proposed by Oliver Grawert
Status: Merged
Approved by: Manuel de la Peña
Approved revision: 315
Merged at revision: 318
Proposed branch: lp:~ogra/phablet-tools/phablet-tools-fix-edge-intro
Merge into: lp:phablet-tools
Diff against target: 27 lines (+7/-3)
1 file modified
phablet-config (+7/-3)
To merge this branch: bzr merge lp:~ogra/phablet-tools/phablet-tools-fix-edge-intro
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+235440@code.launchpad.net

Commit message

phablet-config: move handling of the edge-demo setting into dbus-property-service and do a proper dbus call from phablet-config (LP: #1365725)

Description of the change

phablet-config: move handling of the edge-demo setting into dbus-property-service and do a proper dbus call from phablet-config (LP: #1365725)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Manuel de la Peña (mandel) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'phablet-config'
2--- phablet-config 2014-09-19 17:36:02 +0000
3+++ phablet-config 2014-09-22 11:15:00 +0000
4@@ -237,7 +237,6 @@
5 '/org/freedesktop/Accounts/User32011 %s ' \
6 'string:com.canonical.unity.AccountsService string:demo-edges'
7 getter = fmt % 'org.freedesktop.DBus.Properties.Get'
8- setter = fmt % 'org.freedesktop.DBus.Properties.Set' + ' variant:boolean:'
9
10 enabled = adb.shell(getter).find('true') != -1
11 if args.enable and enabled:
12@@ -245,8 +244,13 @@
13 elif not args.enable and not enabled:
14 print('already disabled')
15 else:
16- setter += 'true' if args.enable else 'false'
17- adb.shell(setter)
18+ setter = 'true' if args.enable else 'false'
19+ dbus_call = 'dbus-send --system --print-reply ' \
20+ '--dest=com.canonical.PropertyService ' \
21+ '/com/canonical/PropertyService ' \
22+ 'com.canonical.PropertyService.SetProperty ' \
23+ 'string:edge boolean:%s' % setter
24+ adb.shell(dbus_call, False)
25
26
27 def _handle_welcome_wizard(adb, args):

Subscribers

People subscribed via source and target branches