Merge lp:~ogra/phablet-tools/fix-socket-location into lp:phablet-tools

Proposed by Oliver Grawert
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 282
Merged at revision: 282
Proposed branch: lp:~ogra/phablet-tools/fix-socket-location
Merge into: lp:phablet-tools
Diff against target: 33 lines (+13/-1)
2 files modified
debian/changelog (+7/-0)
phablet-screenshot (+6/-1)
To merge this branch: bzr merge lp:~ogra/phablet-tools/fix-socket-location
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+222422@code.launchpad.net

Commit message

phablet-screenshot: mirscreencast needs the socket location handed over now that the Mir socket moved to /run/mir_socket (LP: #1327139).

Description of the change

Mir socket location changed, adjust phablet-screenhot for this

To post a comment you must log in.
282. By Oliver Grawert

fix Mir socket location in phablet-screenshot

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:282
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~ogra/phablet-tools/fix-socket-location/+merge/222422/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/341/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-utopic-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-utopic-armhf-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-utopic-i386-ci/22

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/341/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Works fine, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-05-28 13:03:42 +0000
3+++ debian/changelog 2014-06-07 08:31:49 +0000
4@@ -1,3 +1,10 @@
5+phablet-tools (1.0+14.10.20140528.1-0ubuntu2) UNRELEASED; urgency=low
6+
7+ * phablet-screenshot: mirscreencast needs the socket location handed over now
8+ that the Mir socket moved to /run/mir_socket (LP: #1327139).
9+
10+ -- Oliver Grawert <ogra@ubuntu.com> Sat, 07 Jun 2014 10:16:06 +0200
11+
12 phablet-tools (1.0+14.10.20140528.1-0ubuntu1) utopic; urgency=low
13
14 [ Robert Bruce Park ]
15
16=== modified file 'phablet-screenshot'
17--- phablet-screenshot 2014-05-14 13:05:18 +0000
18+++ phablet-screenshot 2014-06-07 08:31:49 +0000
19@@ -111,8 +111,13 @@
20 CONVERTOPTS="$CONVERTOPTS -depth $depth -size $size"
21 MIRFILENAME="/tmp/mir_screencast_$size.$sfx"
22
23+ # for backwards compatibility we check for socket existence and fall
24+ # back to the old location if the new socket does not exist
25+ SOCKET=$(adb shell "ls /run/mir_socket 2>/dev/null | tr -d '\n'")
26+ [ -z "$SOCKET" ] && SOCKET="/tmp/mir_socket"
27+
28 echo "I: Dumping $FBDEV ..."
29- adb shell mirscreencast -m /tmp/mir_socket -n1 -f $MIRFILENAME
30+ adb shell mirscreencast -m $SOCKET -n1 -f $MIRFILENAME
31 adb pull $MIRFILENAME ${PICDIR}/fb
32
33 [ ! -e "${PICDIR}/fb" ] && echo "E: Capture failed!" && return

Subscribers

People subscribed via source and target branches