Ubuntu
sysvinit package

Code review comment for ~ogayot/ubuntu/+source/sysvinit:merge-lp2018596-mantic

  1. Git
  2. lp:~ogayot/ubuntu/+source/sysvinit
  3. merge-lp2018596-mantic
  4. Merge into debian/sid
Revision history for this message
Olivier Gayot (ogayot) wrote :

> This looks good. Thanks! Have you tested the current version? +1, pending your testing if needed. Let me know when ready and I'll sponsor.

Thanks Robie! Yes, upgrade to 3.06-4ubuntu1 is painless and I've been running this version on my laptop without issue. As far as tests go, there is no autopkgtest suite.

> Adding a trailing newline?

Yeah, this newline has been around for a while. I actually moved it to a separate commit in the split view [1] (not sure if that was needed) but it comes back at the merge-changelog step.

[1] https://git.launchpad.net/~ogayot/ubuntu/+source/sysvinit/commit/?h=lp2018596/split/3.06-2ubuntu1&id=b88c0f732d73c5c8e72688e0d6151ef5ec47dfd1 ..

« Back to merge proposal