Code review comment for ~ogayot/ubuntu/+source/sysvinit:merge-lp2018596-mantic
Revision history for this message
| Robie Basak (racb) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
6394e03
(Get the code!)
On Tue, May 09, 2023 at 05:39:09PM -0000, Olivier Gayot wrote:
> How would you feel about dropping the change? I'd also like to take the opportunity to fix the previous changelog entries so that it does not wrongly appear as "Adjust d/rules to fix an arch: all build".
If the delta serves no purpose then we should drop it. And if we can't
figure out any reason for it to exist then it's reasonable to proceed on
the assumption that it serves no purpose. Have you tried asking the
person who originally introduced it?
However, please do not change previous changelog entries. That's
confusing since previous uploads cannot be changed and they will still
contain the old text. I would treat old changelog entries as immutable.
You can however explain what you are doing in the changelog entry
associated with this upload, in plain English prose, including
any historical context you wish.
> I guess unifying in Ubuntu would make sense now. I can work on doing that. I must say that I'm not particularly fan of the derives_from_ubuntu variable being "yes" or "no" but keeping two mechanisms seems worse.
Great - it's appropriate (and I would argue a requirement) to be doing
this kind of cleanup during an Ubuntu package merge. The goal is to make
the delta clean and minimal as that generally correlates with
ensuring correctness and maintainability.
Using "yes" and "no" doesn't seem clean, but AIUI make can only do
string comparisons in its conditional includes, so it's the cleanest way
to do it.
> I have not asked Debian if they would like to carry more delta from us. I think it would be a bit of a burden for Debian but I'm happy to ask if you think that's acceptable.
I appreciate that this delta would be far more invasive, so I leave it
to you to decide what would be most appropriate.
> I sent the fix to Debian back when I added it as a delta in Ubuntu. A few days ago, they included it in 3.07 (currently in experimental).
>
> I'd expect it won't need to be carried as a delta in the next upload.
>
> https:/
Ah, perfect. Thanks! I did look but hadn't spotted that. For this
reason, connecting the dots for other developers can be very useful. For
example, you could use:
d/rules: fix installation of 50-ubuntu-logging when building on Ubuntu (Closes: #1028586)
in the Ubuntu changelog entry.