Merge ~ogayot/debian-cd:fix-2044239 into ~ubuntu-cdimage/debian-cd/+git/ubuntu:main

Proposed by Olivier Gayot
Status: Merged
Merged at revision: 7a04e3159630ad49ffd095b0bbdc299185f41eeb
Proposed branch: ~ogayot/debian-cd:fix-2044239
Merge into: ~ubuntu-cdimage/debian-cd/+git/ubuntu:main
Diff against target: 14 lines (+1/-2)
1 file modified
tools/scanpackages (+1/-2)
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Michael Hudson-Doyle Pending
Review via email: mp+456071@code.launchpad.net

Commit message

tools/scanpackages: fix sed invocation, not using stdin as it should

When stripping signatures from InRelease, we used to pass the output of
sed to gpg. Recently, we changed the logic so that the output of gpg is
passed to sed instead. However, we forgot to drop the second positional
argument of sed - which forces sed to ignore stdin and to operate on the
positional argument instead.

Therefore, the output of gpg gets ignored.

Signed-off-by: Olivier Gayot <email address hidden>

Description of the change

The change is untested (not sure how to run debian-cd) but the change /feels/ sensible to me..

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) :
review: Approve
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Sigh, sorry :(

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tools/scanpackages b/tools/scanpackages
2index 4002cd7..60dd66d 100755
3--- a/tools/scanpackages
4+++ b/tools/scanpackages
5@@ -58,8 +58,7 @@ if [ -e $APT_STATE/lists/*_dists_${CODENAME}_InRelease ]; then
6 # Strip the MD5Sum, SHA1, and SHA256 fields
7 # Update some other information as well
8 gpg --verify --output - $APT_STATE/lists/*_dists_${CODENAME}_InRelease 2>/dev/null | \
9- sed -e "s/^Architectures: .*$/Architectures: $ALL_ARCHES/" \
10- $APT_STATE/lists/*_dists_${CODENAME}_InRelease | \
11+ sed -e "s/^Architectures: .*$/Architectures: $ALL_ARCHES/" | \
12 sed -e "s|^Components: .*$|Components: $COMPONENTS|" | \
13 perl -ne 'if (/^(MD5Sum|SHA1|SHA256):/i) { $f=1; next }
14 if ($f) {

Subscribers

People subscribed via source and target branches