Merge ~ogayot/curtin:lunar-2023-04-03 into curtin:ubuntu/lunar
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Dan Bungert | ||||
Approved revision: | f30a1533f88b753b6fdd3c04699dda9621b632cc | ||||
Merged at revision: | f30a1533f88b753b6fdd3c04699dda9621b632cc | ||||
Proposed branch: | ~ogayot/curtin:lunar-2023-04-03 | ||||
Merge into: | curtin:ubuntu/lunar | ||||
Diff against target: |
42 lines (+19/-1) 2 files modified
curtin/commands/block_meta.py (+2/-1) tests/unittests/test_commands_block_meta.py (+17/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Needs Fixing | |
Dan Bungert | Approve | ||
Review via email: mp+440267@code.launchpad.net |
Commit message
block-meta: fix failed disk lookup when WWN includes extension
curtin's storage config extracts the WWN of a disk from one of the
following udev variables:
* ID_WWN_
* ID_WWN
However, when trying to look the disk up later in the block-meta code,
curtin only tries to match the WWN value against the ID_WWN variable
(and another variable related to DM multipath).
This means that the disk can not be be found just based on the wwn if
the ID_WWN and ID_WWN_
value.
In the past, that was often okay because other fields (such as disk path
or serial) would still make the disk lookup succeed.
However, the following patch introduced a restriction. In v2, all fields
specified must now match for the disk lookup to be successful:
8c5f87ed block_meta: all fields on a disk action must match with v2 config
Fixed by matching against the ID_WWN_
ID_WWN.
(cherry picked from commit 73da3c4f47ea22d
Description of the change
Cherry pick to ubuntu/lunar of the change introduced in https:/
PASSED: Continuous integration, rev:f30a1533f88 b753b6fdd3c0469 9dda9621b632cc /jenkins. canonical. com/server- team/job/ curtin- ci/92/ /jenkins. canonical. com/server- team/job/ curtin- ci/nodes= metal-amd64/ 92/ /jenkins. canonical. com/server- team/job/ curtin- ci/nodes= metal-arm64/ 92/ /jenkins. canonical. com/server- team/job/ curtin- ci/nodes= metal-ppc64el/ 92/ /jenkins. canonical. com/server- team/job/ curtin- ci/nodes= metal-s390x/ 92/
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild: /jenkins. canonical. com/server- team/job/ curtin- ci/92// rebuild
https:/