Merge ~oem-solutions-group/pc-enablement/+git/oem-volatile-task-stella:lp1998573 into ~oem-solutions-group/pc-enablement/+git/oem-volatile-task-stella:main

Proposed by jeremyszu
Status: Merged
Approved by: jeremyszu
Approved revision: 4d61ade1b34bf61e9b33437ecdabd664019ff9ac
Merged at revision: a156565c1a8099c3d5866cd3f210b1b24bb188db
Proposed branch: ~oem-solutions-group/pc-enablement/+git/oem-volatile-task-stella:lp1998573
Merge into: ~oem-solutions-group/pc-enablement/+git/oem-volatile-task-stella:main
Diff against target: 35 lines (+13/-0)
3 files modified
debian/changelog (+6/-0)
debian/install (+1/-0)
usr/share/ubuntu/scripts/oem-config.d/late/90_remove-volatile-task (+6/-0)
Reviewer Review Type Date Requested Status
Andy Chi Approve
Bin Li Pending
OEM Solutions Group Pending
Review via email: mp+434882@code.launchpad.net

Commit message

    Remove self and common volatile-task

    The volatile-tasks are designed to be removed after installation (if
    success). (LP: #1998573)

To post a comment you must log in.
Revision history for this message
jeremyszu (os369510) wrote :

+++ Run hook scripts in /usr/share/ubuntu/scripts/oem-config.d/late:
+ run-parts -v --report /usr/share/ubuntu/scripts/oem-config.d/late
run-parts: executing /usr/share/ubuntu/scripts/oem-config.d/late/70_create-recover-media
run-parts: executing /usr/share/ubuntu/scripts/oem-config.d/late/90_cleanup
run-parts: executing /usr/share/ubuntu/scripts/oem-config.d/late/90_remove-volatile-task

Purging configuration files for oem-volatile-task-stella (1.0-ubuntu3) ...

---

$ dpkg -l | grep volatile-task; echo $?
1

Revision history for this message
Andy Chi (andch) wrote :

Confirmed that it'll remove oem-volatile-task after installation.

LGTM.

review: Approve
Revision history for this message
jeremyszu (os369510) wrote :

Also push to jammy

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index f060925..f1f3e49 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+oem-volatile-task-stella (1.0-ubuntu3) jammy; urgency=medium
7+
8+ * Remove volatile-task(s) after OOBE. (LP: #1998573)
9+
10+ -- Jeremy Szu <jeremy.szu@canonical.com> Tue, 14 Feb 2023 10:02:26 +0000
11+
12 oem-volatile-task-stella (1.0-ubuntu2) jammy; urgency=medium
13
14 * Workaround config made by nvidia-prime (LP: #1996170)
15diff --git a/debian/install b/debian/install
16index 4ebbcfc..e8a0526 100644
17--- a/debian/install
18+++ b/debian/install
19@@ -2,3 +2,4 @@ lib/* /usr/share/volatile/
20 bin /usr/share/volatile/
21 task /usr/share/volatile/
22 server-chroottask /usr/share/volatile/
23+usr/share/ubuntu/scripts/* /usr/share/ubuntu/scripts/
24diff --git a/usr/share/ubuntu/scripts/oem-config.d/late/90_remove-volatile-task b/usr/share/ubuntu/scripts/oem-config.d/late/90_remove-volatile-task
25new file mode 100755
26index 0000000..660b713
27--- /dev/null
28+++ b/usr/share/ubuntu/scripts/oem-config.d/late/90_remove-volatile-task
29@@ -0,0 +1,6 @@
30+#!/bin/bash
31+
32+apt-get -o Acquire::http::No-Cache=True \
33+ -o Acquire::Retries=3 \
34+ -o APT::Get::AllowUnauthenticated=true \
35+ remove --purge --yes oem-volatile-task-stella oem-volatile-task

Subscribers

People subscribed via source and target branches

to all changes: