Merge lp:~oem-qa/checkbox/patch_exit_on_whitelist_file_not_found into lp:checkbox

[Javier Collado]

Print error message and exit on whitelist/blacklist file not found

When a user mistypes the name of the whitelist/blacklist file in the command line:
- checkbox execution isn't stopped even if the file doesn't exist
- just an info line is displayed in logs: "Failed to open file '%s': %s"
- whitelist/blacklist patterns aren't applied (without providing any feedback regarding the reason to the user)

With this change:
- filenames passed through the command line are checked
- if a file doesn't exist an error message is printed to stderr and the application exits

Low level details:
- Logging level for the error messsage set to critical since this problem now causes the whole application to exit abruptly.
- Exit code is set to EX_NOINPUT which is the recommended one for files not found or not readable.

[Daniel Manrique (roadmr)]

Thanks Javier, this works fine with both the shorthand and extended whitelist/blacklist syntax, I just added a gettext.gettext call to the error string.

review: Approve

=== modified file 'plugins/jobs_info.py'
--- plugins/jobs_info.py	2011-01-12 21:08:53 +0000
+++ plugins/jobs_info.py	2011-07-13 14:22:30 +0000
@@ -16,7 +16,7 @@
 # You should have received a copy of the GNU General Public License
 # along with Checkbox.  If not, see <http://www.gnu.org/licenses/>.
 #
-import re
+import os, sys, re
 import gettext
 import logging
 
@@ -78,8 +78,11 @@
             try:
                 file = open(filename)
             except IOError, e:
-                logging.info("Failed to open file '%s': %s",
-                    filename, e.strerror)
+                error_message=("Failed to open file '%s': %s"
+                               % (filename, e.strerror))
+                logging.critical(error_message)
+                sys.stderr.write("%s\n" % error_message)
+                sys.exit(os.EX_NOINPUT)
             else:
                 strings.extend([l.strip() for l in file.readlines()])