Merge ~oddbloke/ubuntu/+source/simplestreams:new_upstream_snapshot into ubuntu/+source/simplestreams:ubuntu/devel

Proposed by Dan Watkins
Status: Merged
Approved by: Bryce Harrington
Approved revision: 2c37036fec890d82935690e7cf64580ecf1af77d
Merged at revision: 2c37036fec890d82935690e7cf64580ecf1af77d
Proposed branch: ~oddbloke/ubuntu/+source/simplestreams:new_upstream_snapshot
Merge into: ubuntu/+source/simplestreams:ubuntu/devel
Diff against target: 141 lines (+22/-24)
8 files modified
debian/changelog (+11/-0)
debian/control (+0/-18)
debian/rules (+5/-3)
dev/null (+0/-1)
tools/js2signed (+1/-1)
tools/make-test-data (+3/-0)
tools/sign-examples (+1/-1)
tox.ini (+1/-0)
Reviewer Review Type Date Requested Status
Bryce Harrington (community) Approve
Review via email: mp+376423@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Code changes look good, the PPA you set up has built successfully:

https://launchpad.net/~daniel-thewatkins/+archive/ubuntu/streams/+packages

Due to LP: #1734657, git ubuntu is not able to build the source package, but I've used the .dsc from the ppa for the upload, and pushed the upload tag for this branch:

$ git push pkg upload/0.1.0-30-g3cc8988a-0ubuntu1
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/simplestreams
 * [new tag] upload/0.1.0-30-g3cc8988a-0ubuntu1 -> upload/0.1.0-30-g3cc8988a-0ubuntu1

$ dput ubuntu simplestreams_0.1.0-30-g3cc8988a-0ubuntu1_source.changes
Checking signature on .changes
gpg: /home/bryce/ubuntu/SimpleStreams/focal/simplestreams_0.1.0-30-g3cc8988a-0ubuntu1_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: /home/bryce/ubuntu/SimpleStreams/focal/simplestreams_0.1.0-30-g3cc8988a-0ubuntu1.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading simplestreams_0.1.0-30-g3cc8988a-0ubuntu1.dsc: done.
  Uploading simplestreams_0.1.0-30-g3cc8988a.orig.tar.gz: done.
  Uploading simplestreams_0.1.0-30-g3cc8988a-0ubuntu1.debian.tar.xz: done.
  Uploading simplestreams_0.1.0-30-g3cc8988a-0ubuntu1_source.buildinfo: done.
  Uploading simplestreams_0.1.0-30-g3cc8988a-0ubuntu1_source.changes: done.
Successfully uploaded packages.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 41e1af5..a0a278e 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,14 @@
6+simplestreams (0.1.0-30-g3cc8988a-0ubuntu1) focal; urgency=medium
7+
8+ * New upstream snapshot.
9+ - tools/js2signed: change shebang to /usr/bin/env python3
10+ - Fix file matching for disk-kvm.img [Stéphane Graber]
11+ - Add combined-disk-kvm-img_sha256 to download.json [Stéphane Graber]
12+ - debian: run the tests only against Python 3 [Paride Legovini]
13+ - debian: stop building Python 2 package
14+
15+ -- Daniel Watkins <oddbloke@ubuntu.com> Thu, 05 Dec 2019 10:51:04 -0500
16+
17 simplestreams (0.1.0-25-gba75825b-0ubuntu1) eoan; urgency=medium
18
19 * New upstream snapshot.
20diff --git a/debian/control b/debian/control
21index 350b2d0..d6fc372 100644
22--- a/debian/control
23+++ b/debian/control
24@@ -5,15 +5,6 @@ Standards-Version: 4.2.1
25 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26 Build-Depends: debhelper (>= 7),
27 dh-python,
28- python-all,
29- python-glanceclient,
30- python-keystoneclient,
31- python-mock,
32- python-nose,
33- python-requests (>= 1.1),
34- python-setuptools,
35- python-swiftclient,
36- python-yaml,
37 python3,
38 python3-flake8,
39 python3-glanceclient,
40@@ -46,15 +37,6 @@ Description: Library and tools for using Simple Streams data
41 This package provides a client for interacting with simple
42 streams data as is produced to describe Ubuntu's cloud images.
43
44-Package: python-simplestreams
45-Architecture: all
46-Priority: optional
47-Depends: gnupg, python-boto, ${misc:Depends}, ${python:Depends}
48-Suggests: python-requests (>= 1.1)
49-Description: Library and tools for using Simple Streams data
50- This package provides a client for interacting with simple
51- streams data as is produced to describe Ubuntu's cloud images.
52-
53 Package: python3-simplestreams-openstack
54 Architecture: all
55 Priority: optional
56diff --git a/debian/python-simplestreams.install b/debian/python-simplestreams.install
57deleted file mode 100644
58index 0236cd1..0000000
59--- a/debian/python-simplestreams.install
60+++ /dev/null
61@@ -1 +0,0 @@
62-usr/lib/python2*/*-packages/simplestreams/*
63diff --git a/debian/rules b/debian/rules
64index bc93943..3e02246 100755
65--- a/debian/rules
66+++ b/debian/rules
67@@ -1,14 +1,16 @@
68 #!/usr/bin/make -f
69
70 export SS_REQUIRE_DISTRO_INFO = 0
71-PYVERS := $(shell pyversions -r)
72 PY3VERS := $(shell py3versions -r)
73 %:
74- dh $@ --with=python2,python3
75+ dh $@ --with=python3
76
77 override_dh_auto_install:
78 dh_auto_install
79- set -ex; for python in $(PY3VERS) $(PYVERS); do \
80+ set -ex; for python in $(PY3VERS); do \
81 $$python setup.py build --executable=/usr/bin/python3 && \
82 $$python setup.py install --root=$(CURDIR)/debian/tmp --install-layout=deb; \
83 done
84+
85+override_dh_auto_test:
86+ make test3
87diff --git a/tools/js2signed b/tools/js2signed
88index b02054b..2b66e5f 100755
89--- a/tools/js2signed
90+++ b/tools/js2signed
91@@ -1,4 +1,4 @@
92-#!/usr/bin/env python
93+#!/usr/bin/env python3
94 # Copyright (C) 2013 Canonical Ltd.
95 #
96 # Author: Scott Moser <scott.moser@canonical.com>
97diff --git a/tools/make-test-data b/tools/make-test-data
98index a1e183d..7a39843 100755
99--- a/tools/make-test-data
100+++ b/tools/make-test-data
101@@ -298,8 +298,10 @@ def create_fake_file(prefix, item):
102 # - combined_sha256 and combined_rootxz_sha256 for the -root.tar.gz
103 # - combined_squashfs_sha256 for the squashfs
104 # - combined_disk1-img_sha256 for the img
105+ # - combined_disk-kvm-img_sha256 for the img
106 ftype = item['ftype']
107 for name, extension in (('disk1-img', '.img'),
108+ ('disk-kvm-img', 'disk-kvm.img'),
109 ('rootxz', '-root.tar.xz'),
110 ('squashfs', '.squashfs')):
111 if (ftype == "lxd.tar.xz" and
112@@ -570,6 +572,7 @@ def create_image_data(query_tree, out_d, streamdir):
113
114 # find calculated combined checksums
115 for name, extension in (('disk1-img', '.img'),
116+ ('disk-kvm-img', 'disk-kvm.img'),
117 ('rootxz', '-root.tar.xz'),
118 ('squashfs', '.squashfs')):
119 root = lxd.replace('-lxd.tar.xz', extension)
120diff --git a/tools/sign-examples b/tools/sign-examples
121index 9b549d2..89d5dd8 100755
122--- a/tools/sign-examples
123+++ b/tools/sign-examples
124@@ -6,4 +6,4 @@ FILES=( ${TOP_DIR}/examples/*/streams/v1/*.json )
125 force=""
126 [ "$1" = "--force" ] && force="$1"
127
128-"${TOP_DIR}/tools/js2signed" $force "${FILES[@]}"
129+$SS_PYTHON "${TOP_DIR}/tools/js2signed" $force "${FILES[@]}"
130diff --git a/tox.ini b/tox.ini
131index 654652e..3c8634f 100644
132--- a/tox.ini
133+++ b/tox.ini
134@@ -4,6 +4,7 @@ envlist = py27, py3, flake8
135 [testenv]
136 setenv =
137 GNUPGHOME={toxinidir}/gnupg
138+ SS_PYTHON={envpython}
139 commands =
140 {toxinidir}/tools/create-gpgdir
141 {toxinidir}/tools/sign-examples

Subscribers

People subscribed via source and target branches