Merge lp:~oddbloke/livecd-rootfs/minimized-skips-xenial into lp:~ubuntu-core-dev/livecd-rootfs/xenial-proposed

Proposed by Dan Watkins
Status: Merged
Merged at revision: 1454
Proposed branch: lp:~oddbloke/livecd-rootfs/minimized-skips-xenial
Merge into: lp:~ubuntu-core-dev/livecd-rootfs/xenial-proposed
Diff against target: 72 lines (+33/-0)
4 files modified
debian/changelog (+7/-0)
live-build/ubuntu-cpc/hooks/040-vmdk-image.binary (+9/-0)
live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary (+8/-0)
live-build/ubuntu-cpc/hooks/042-vagrant.binary (+9/-0)
To merge this branch: bzr merge lp:~oddbloke/livecd-rootfs/minimized-skips-xenial
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+341767@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dan Watkins (oddbloke) wrote :

Oops, don't have the bug reference in the changelog; fixing now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2017-12-21 09:12:41 +0000
3+++ debian/changelog 2018-03-20 20:11:42 +0000
4@@ -1,3 +1,10 @@
5+livecd-rootfs (2.408.28) xenial; urgency=medium
6+
7+ * ubuntu-cpc: When performing a minimized build, don't generate artifacts
8+ that won't boot with the linux-kvm kernel (LP: #1757223).
9+
10+ -- Daniel Watkins <daniel.watkins@canonical.com> Tue, 20 Mar 2018 12:42:25 -0400
11+
12 livecd-rootfs (2.408.27) xenial; urgency=medium
13
14 * Don't ask for password and GECOS while creating vagrant user
15
16=== modified file 'live-build/ubuntu-cpc/hooks/040-vmdk-image.binary'
17--- live-build/ubuntu-cpc/hooks/040-vmdk-image.binary 2017-05-12 19:20:22 +0000
18+++ live-build/ubuntu-cpc/hooks/040-vmdk-image.binary 2018-03-20 20:11:42 +0000
19@@ -3,6 +3,15 @@
20 #
21 # Generate VMDK files
22
23+case ${SUBPROJECT:-} in
24+ minimized)
25+ echo "Skipping minimized $0 build as images won't boot with linux-kvm"
26+ exit 0
27+ ;;
28+ *)
29+ ;;
30+esac
31+
32 extension="disk1.vmdk"
33
34 case $ARCH in
35
36=== modified file 'live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary'
37--- live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary 2017-03-17 18:34:22 +0000
38+++ live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary 2018-03-20 20:11:42 +0000
39@@ -9,6 +9,14 @@
40 #
41 # For this step, we re-use the VMDK's made in 040-vmdk-image.binary
42
43+case ${SUBPROJECT:-} in
44+ minimized)
45+ echo "Skipping minimized $0 build as images won't boot with linux-kvm"
46+ exit 0
47+ ;;
48+ *)
49+ ;;
50+esac
51
52 # Switch on $ARCH to determine which ID and description to use in the produced
53 # OVF. We have fancy Ubuntu-specific IDs in the OVF specification, we might as
54
55=== modified file 'live-build/ubuntu-cpc/hooks/042-vagrant.binary'
56--- live-build/ubuntu-cpc/hooks/042-vagrant.binary 2017-12-21 08:49:49 +0000
57+++ live-build/ubuntu-cpc/hooks/042-vagrant.binary 2018-03-20 20:11:42 +0000
58@@ -15,6 +15,15 @@
59 # some packages in it, convert it to a vmdk, and then assemble the vagrant
60 # box.
61
62+case ${SUBPROJECT:-} in
63+ minimized)
64+ echo "Skipping minimized $0 build as images won't boot with linux-kvm"
65+ exit 0
66+ ;;
67+ *)
68+ ;;
69+esac
70+
71 cur_d=${PWD}
72 my_d=$(dirname $(readlink -f ${0}))
73

Subscribers

People subscribed via source and target branches