curtin

Merge ~oddbloke/curtin/+git/curtin:vmtest-remove-release into curtin:master

  1. Git
  2. lp:~oddbloke/curtin/+git/curtin
  3. vmtest-remove-release
  4. Merge into master
Proposed by Dan Watkins
Status: Merged
Approved by: Dan Watkins
Approved revision: 56ab641cb7355322bf13f6b3b0c5096835acd54f
Merge reported by: Server Team CI bot
Merged at revision: not available
Proposed branch: ~oddbloke/curtin/+git/curtin:vmtest-remove-release
Merge into: curtin:master
Diff against target: 34 lines (+2/-2)
2 files modified
tools/run-pep8 (+1/-1)
tools/vmtest-remove-release (+1/-1)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Ryan Harper (community) Approve
curtin developers Pending
Review via email: mp+387527@code.launchpad.net

Commit message

tools: rename remove-vmtest-release to vmtest-remove-release

This prefix matches other vmtest scripts we have in tools/, making it
easier to discover.

(Also make it executable.)

To post a comment you must log in.
Revision history for this message
Ryan Harper (raharper) wrote :

This looks great. Thanks!

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:56ab641cb7355322bf13f6b3b0c5096835acd54f
https://jenkins.ubuntu.com/server/job/curtin-ci/159/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/159/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/159/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/159/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/159/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/159//rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tools/run-pep8 b/tools/run-pep8
2index c27a96c..227129c 100755
3--- a/tools/run-pep8
4+++ b/tools/run-pep8
5@@ -9,10 +9,10 @@ pycheck_dirs=(
6 "tools/block-discover-to-config"
7 "tools/curtin-log-print"
8 "tools/noproxy"
9- "tools/remove-vmtest-release"
10 "tools/schema-validate-storage"
11 "tools/ssh-keys-list"
12 "tools/vmtest-filter"
13+ "tools/vmtest-remove-release"
14 "tools/vmtest-sync-images"
15 "tools/webserv"
16 "tools/write-curtin"
17diff --git a/tools/remove-vmtest-release b/tools/vmtest-remove-release
18similarity index 97%
19rename from tools/remove-vmtest-release
20rename to tools/vmtest-remove-release
21old mode 100644
22new mode 100755
23index 8ab9b2e..d2c5f83
24--- a/tools/remove-vmtest-release
25+++ b/tools/vmtest-remove-release
26@@ -36,7 +36,7 @@ def clean_file(fname, distro):
27
28 if __name__ == "__main__":
29 parser = argparse.ArgumentParser(
30- prog="remove-vmtest-release",
31+ prog="vmtest-remove-release",
32 description="Tool to remove vmtest classes by distro release")
33 parser.add_argument('--distro-release', '-d',
34 action='store', required=True)

Subscribers

People subscribed via source and target branches