Code review comment for lp:~oddbloke/cloud-init/lp1506187
Revision history for this message
| Ben Howard (darkmuggle-deactivatedaccount) wrote | # |
review:
Approve
© 2004-2023
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
886068b
(Get the code!)
Adding Scott to the reviewers for merge approval and merging.
This change looks sane to me and reduces the complexity of the Datasource. Microsoft has updated the public facing documentation to reflect the use of the system uuid as extracted from dmi data as the authoratative identification of an instance.
We are seeing this as a hot issue. So once this lands in Xenial, I'll run an SRU to get this backported.
+1