Merge lp:~oddbloke/cloud-init/bigstep into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Dan Watkins
Status: Rejected
Rejected by: Dan Watkins
Proposed branch: lp:~oddbloke/cloud-init/bigstep
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
cloudinit/settings.py (+1/-0)
To merge this branch: bzr merge lp:~oddbloke/cloud-init/bigstep
Reviewer Review Type Date Requested Status
Scott Moser Pending
Review via email: mp+288105@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Scott Moser (smoser) wrote :

i'll comment here with what i said to Daniel in irc

<smoser> Odd_Bloke, when you dont have that file there..
<smoser> i dontrecall. does cloud-init warn that the ds raised exception ?
<smoser> can you just try and catch the load_file and return false if not there ?

ie, it'd be nice for this ds to not raise exception on get-data when in fact there was no exception, but rather it just did not find any data.

Revision history for this message
Dan Watkins (oddbloke) wrote :

Unmerged revisions

1176. By Dan Watkins

Enable the Bigstep data source in the default configuration

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cloudinit/settings.py'
2--- cloudinit/settings.py 2015-03-04 17:42:34 +0000
3+++ cloudinit/settings.py 2016-03-04 14:25:20 +0000
4@@ -42,6 +42,7 @@
5 'CloudSigma',
6 'CloudStack',
7 'SmartOS',
8+ 'Bigstep',
9 # At the end to act as a 'catch' when none of the above work...
10 'None',
11 ],