Merge ~oddbloke/cloud-images/+git/mfdiff:bugfix/kernels into ~cloud-images-release-managers/cloud-images/+git/mfdiff:master

Proposed by Dan Watkins
Status: Merged
Merged at revision: d4dc8ffcc6cec0a576f68ffb40b0b7401824d862
Proposed branch: ~oddbloke/cloud-images/+git/mfdiff:bugfix/kernels
Merge into: ~cloud-images-release-managers/cloud-images/+git/mfdiff:master
Diff against target: 42 lines (+24/-0)
2 files modified
test/test_manifestdiff.py (+21/-0)
ubuntu/cloudimage/mfdiff/manifest.py (+3/-0)
Reviewer Review Type Date Requested Status
Robert C Jennings (community) Approve
Francis Ginther (community) Approve
Review via email: mp+360832@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

Approve

review: Approve
Revision history for this message
Robert C Jennings (rcj) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/test/test_manifestdiff.py b/test/test_manifestdiff.py
2index 3f6cfec..3d33731 100644
3--- a/test/test_manifestdiff.py
4+++ b/test/test_manifestdiff.py
5@@ -126,3 +126,24 @@ class TestManifestDiff(object):
6 assert added_packages == {'package2': '1.0', 'package3': '1.0'}
7 assert removed_packages == {'package7': '1.0', 'package8': '1.0'}
8 assert changed_packages == ['package4', 'package5']
9+
10+ def test_kernel_fixups(self, tmpdir):
11+ package_list1 = [('linux-image-4.13.0-16-generic', '4.13.0-16.19')]
12+ package_list2 = [('linux-image-4.13.0-25-generic', '4.13.0-25.29')]
13+
14+ manifest_file1 = tmpdir.join('manifest1')
15+ manifest_file2 = tmpdir.join('manifest2')
16+ write_manifest_file(manifest_file1, package_list1)
17+ write_manifest_file(manifest_file2, package_list2)
18+
19+ manifest1 = Manifest(str(manifest_file1), 'bionic', 'amd64')
20+ manifest2 = Manifest(str(manifest_file2), 'bionic', 'amd64')
21+ diff = ManifestDiff(manifest1, manifest2)
22+
23+ added_packages = diff.get_added()
24+ removed_packages = diff.get_removed()
25+ changed_packages = diff.get_changed()
26+
27+ assert added_packages == {}
28+ assert removed_packages == {}
29+ assert changed_packages == ['linux-image-4.13.0-25-generic']
30diff --git a/ubuntu/cloudimage/mfdiff/manifest.py b/ubuntu/cloudimage/mfdiff/manifest.py
31index 2ac24ba..6907ad8 100644
32--- a/ubuntu/cloudimage/mfdiff/manifest.py
33+++ b/ubuntu/cloudimage/mfdiff/manifest.py
34@@ -36,6 +36,9 @@ class Manifest(object):
35 def __getitem__(self, key):
36 return self.dict[key]
37
38+ def __setitem__(self, key, value):
39+ self.dict[key] = value
40+
41 def __delitem__(self, key):
42 del self.dict[key]
43

Subscribers

People subscribed via source and target branches