Apport

Merge lp:~oddbloke/apport/lp1884221 into lp:~ubuntu-core-dev/ubuntu/groovy/apport/ubuntu

  1. lp1884221
  2. Merge into ubuntu
Proposed by Dan Watkins
Status: Merged
Merged at revision: 2804
Proposed branch: lp:~oddbloke/apport/lp1884221
Merge into: lp:~ubuntu-core-dev/ubuntu/groovy/apport/ubuntu
Diff against target: 32 lines (+10/-3)
2 files modified
apport/crashdb_impl/launchpad.py (+3/-3)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~oddbloke/apport/lp1884221
Reviewer Review Type Date Requested Status
Brian Murray Approve
Review via email: mp+386269@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

Thanks for the fix!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'apport/crashdb_impl/launchpad.py'
2--- apport/crashdb_impl/launchpad.py 2020-06-08 12:35:24 +0000
3+++ apport/crashdb_impl/launchpad.py 2020-06-23 17:26:36 +0000
4@@ -239,10 +239,10 @@
5
6 hostname = self.get_hostname()
7
8- if self.options.get('project'):
9+ if 'SnapSource' in report:
10+ project = report['SnapSource']
11+ else:
12 project = self.options.get('project')
13- elif 'SnapSource' in report:
14- project = report['SnapSource']
15
16 if not project:
17 if 'SourcePackage' in report:
18
19=== modified file 'debian/changelog'
20--- debian/changelog 2020-06-10 19:30:51 +0000
21+++ debian/changelog 2020-06-23 17:26:36 +0000
22@@ -1,3 +1,10 @@
23+apport (2.20.11-0ubuntu41) UNRELEASED; urgency=medium
24+
25+ * apport/crashdb_impl/launchpad.py: ensure that project will always be set
26+ in get_comment_url. (LP: #1884221)
27+
28+ -- Daniel Watkins <oddbloke@ubuntu.com> Tue, 23 Jun 2020 13:23:20 -0400
29+
30 apport (2.20.11-0ubuntu40) groovy; urgency=medium
31
32 * Build-depend on python3-requests-unixsocket.

Subscribers

People subscribed via source and target branches