Merge lp:~nuthinking/ubiquity-slideshow-ubuntu/hover-welcome into lp:ubiquity-slideshow-ubuntu

Proposed by Christian Giordano
Status: Merged
Merge reported by: Dylan McCall
Merged at revision: not available
Proposed branch: lp:~nuthinking/ubiquity-slideshow-ubuntu/hover-welcome
Merge into: lp:ubiquity-slideshow-ubuntu
Diff against target: 17 lines (+4/-0)
1 file modified
slideshows/ubuntu/slides/link/base.css (+4/-0)
To merge this branch: bzr merge lp:~nuthinking/ubiquity-slideshow-ubuntu/hover-welcome
Reviewer Review Type Date Requested Status
Dylan McCall Approve
Review via email: mp+94508@code.launchpad.net

Description of the change

Added hover effect to links and replaced intro background

To post a comment you must log in.
Revision history for this message
Dylan McCall (dylanmccall) wrote :

I did remember the other reason we didn't have a hover effect: when someone just chooses Install (instead of "Try Ubuntu first"), clicking a link in the slideshow won't do anything (there's no web browser to open). So, they're less link-like for that reason. With that said, they still did the pointing cursor, so it wasn't exactly happening anyway.

Let's see how this goes :)
I'm making one change, so the special hover state only happens for links inside .text.

Background looks pretty. Thank you!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'slideshows/ubuntu/slides/link/base.css'
2--- slideshows/ubuntu/slides/link/base.css 2012-01-24 03:55:55 +0000
3+++ slideshows/ubuntu/slides/link/base.css 2012-02-24 09:27:17 +0000
4@@ -52,6 +52,10 @@
5 display:inline;
6 }
7
8+a:hover {
9+ text-decoration:underline;
10+}
11+
12 #wrapper {
13 position:absolute;
14
15
16=== modified file 'slideshows/ubuntu/slides/screenshots/welcome.jpg'
17Binary files slideshows/ubuntu/slides/screenshots/welcome.jpg 2011-09-28 13:35:02 +0000 and slideshows/ubuntu/slides/screenshots/welcome.jpg 2012-02-24 09:27:17 +0000 differ

Subscribers

People subscribed via source and target branches