Merge lp:~numerigraphe/openobject-server/trunk-bug525808-mutable-defaults into lp:openobject-server

[Numérigraphe]

This branch replaces some mutable default values with None in report, base, safe_eval and history.
That should get us rid of the last bits of Bug #525808 in the server.
Lionel.

=== modified file 'history/check_profile_l10n_all.py'
--- history/check_profile_l10n_all.py	2011-09-26 00:54:44 +0000
+++ history/check_profile_l10n_all.py	2011-11-07 15:51:24 +0000
@@ -63,7 +63,9 @@
         time.sleep(3)
     return True
 
-def wizard_run(wizname, fieldvalues={}, endstate='end'):
+def wizard_run(wizname, fieldvalues=None, endstate='end'):
+    if fieldvalues is None:
+        fieldvalues = {}
     wiz_id = sock4.create(dbname, uid, 'admin', wizname)
     state = 'init'
     datas = {'form':{}}

=== modified file 'openerp/addons/base/ir/ir_default.py'
--- openerp/addons/base/ir/ir_default.py	2009-10-20 10:52:23 +0000
+++ openerp/addons/base/ir/ir_default.py	2011-11-07 15:51:24 +0000
@@ -34,7 +34,7 @@
         'company_id': fields.many2one('res.company','Company')
     }
 
-    def _get_company_id(self, cr, uid, context={}):
+    def _get_company_id(self, cr, uid, context=None):
         res = self.pool.get('res.users').read(cr, uid, [uid], ['company_id'], context=context)
         if res and res[0]['company_id']:
             return res[0]['company_id'][0]

=== modified file 'openerp/addons/base/ir/ir_filters.py'
--- openerp/addons/base/ir/ir_filters.py	2011-08-06 00:50:46 +0000
+++ openerp/addons/base/ir/ir_filters.py	2011-11-07 15:51:24 +0000
@@ -53,7 +53,7 @@
             return False
         return self.create(cr, uid, vals, context)
 
-    def _auto_init(self, cr, context={}):
+    def _auto_init(self, cr, context=None):
         super(ir_filters, self)._auto_init(cr, context)
         # Use unique index to implement unique constraint on the lowercase name (not possible using a constraint)
         cr.execute("SELECT indexname FROM pg_indexes WHERE indexname = 'ir_filters_name_model_uid_unique_index'")

=== modified file 'openerp/addons/base/ir/ir_model.py'
--- openerp/addons/base/ir/ir_model.py	2011-10-17 13:37:02 +0000
+++ openerp/addons/base/ir/ir_model.py	2011-11-07 15:51:24 +0000
@@ -161,7 +161,7 @@
             #pooler.restart_pool(cr.dbname)
         return res
 
-    def instanciate(self, cr, user, model, context={}):
+    def instanciate(self, cr, user, model, context=None):
         class x_custom_model(osv.osv):
             pass
         x_custom_model._name = model

=== modified file 'openerp/addons/base/ir/ir_sequence.py'
--- openerp/addons/base/ir/ir_sequence.py	2011-10-07 14:54:06 +0000
+++ openerp/addons/base/ir/ir_sequence.py	2011-11-07 15:51:24 +0000
@@ -38,7 +38,7 @@
         ('code_unique', 'unique(code)', '`code` must be unique.'),
     ]
 
-def _code_get(self, cr, uid, context={}):
+def _code_get(self, cr, uid, context=None):
     cr.execute('select code, name from ir_sequence_type')
     return cr.fetchall()
 

=== modified file 'openerp/addons/base/ir/ir_translation.py'
--- openerp/addons/base/ir/ir_translation.py	2011-09-13 17:43:10 +0000
+++ openerp/addons/base/ir/ir_translation.py	2011-11-07 15:51:24 +0000
@@ -62,7 +62,7 @@
         'xml_id': fields.char('External ID', size=128, help='Maps to the ir_model_data for which this translation is provided.'),
     }
 
-    def _auto_init(self, cr, context={}):
+    def _auto_init(self, cr, context=None):
         super(ir_translation, self)._auto_init(cr, context)
 
         # FIXME: there is a size limit on btree indexed values so we can't index src column with normal btree. 

=== modified file 'openerp/addons/base/ir/ir_ui_view.py'
--- openerp/addons/base/ir/ir_ui_view.py	2011-09-19 22:48:50 +0000
+++ openerp/addons/base/ir/ir_ui_view.py	2011-11-07 15:51:24 +0000
@@ -109,7 +109,7 @@
                       (view_id, model))
         return cr.fetchall()
 
-    def write(self, cr, uid, ids, vals, context={}):
+    def write(self, cr, uid, ids, vals, context=None):
         if not isinstance(ids, (list, tuple)):
             ids = [ids]
         result = super(view, self).write(cr, uid, ids, vals, context)
@@ -122,7 +122,7 @@
 
         return result
 
-    def graph_get(self, cr, uid, id, model, node_obj, conn_obj, src_node, des_node,label,scale,context={}):
+    def graph_get(self, cr, uid, id, model, node_obj, conn_obj, src_node, des_node, label, scale, context=None):
         if not label:
             label = []
         nodes=[]

=== modified file 'openerp/addons/base/ir/workflow/print_instance.py'
--- openerp/addons/base/ir/workflow/print_instance.py	2011-06-14 06:52:57 +0000
+++ openerp/addons/base/ir/workflow/print_instance.py	2011-11-07 15:51:24 +0000
@@ -210,7 +210,7 @@
         else:
             return (False, False, False)
 
-    def create(self, cr, uid, ids, data, context={}):
+    def create(self, cr, uid, ids, data, context=None):
         self.obj = report_graph_instance(cr, uid, ids, data)
         return (self.obj.get(), 'pdf')
 

=== modified file 'openerp/addons/base/ir/workflow/workflow.py'
--- openerp/addons/base/ir/workflow/workflow.py	2011-09-19 22:48:50 +0000
+++ openerp/addons/base/ir/workflow/workflow.py	2011-11-07 15:51:24 +0000
@@ -45,7 +45,7 @@
         wf_service.clear_cache(cr, user)
         return super(workflow, self).write(cr, user, ids, vals, context=context)
 
-    def get_active_workitems(self, cr, uid, res, res_id, context={}):
+    def get_active_workitems(self, cr, uid, res, res_id, context=None):
         
         cr.execute('select * from wkf where osv=%s limit 1',(res,))
         wkfinfo = cr.dictfetchone()
@@ -212,7 +212,7 @@
         'instance_id': fields.many2one('workflow.instance', 'Destination Instance', ondelete="cascade"),
         'workitem_id': fields.many2one('workflow.workitem', 'Workitem', required=True, ondelete="cascade"),
     }
-    def _auto_init(self, cr, context={}):
+    def _auto_init(self, cr, context=None):
         super(wkf_triggers, self)._auto_init(cr, context)
         cr.execute('SELECT indexname FROM pg_indexes WHERE indexname = \'wkf_triggers_res_id_model_index\'')
         if not cr.fetchone():

=== modified file 'openerp/addons/base/module/module.py'
--- openerp/addons/base/module/module.py	2011-10-05 14:23:15 +0000
+++ openerp/addons/base/module/module.py	2011-11-07 15:51:24 +0000
@@ -402,7 +402,7 @@
         }
 
     # update the list of available packages
-    def update_list(self, cr, uid, context={}):
+    def update_list(self, cr, uid, context=None):
         res = [0, 0] # [update, add]
 
         known_mods = self.browse(cr, uid, self.search(cr, uid, []))

=== modified file 'openerp/addons/base/res/ir_property.py'
--- openerp/addons/base/res/ir_property.py	2011-01-10 17:29:49 +0000
+++ openerp/addons/base/res/ir_property.py	2011-11-07 15:51:24 +0000
@@ -156,7 +156,7 @@
             return time.strftime('%Y-%m-%d', time.strptime(record.value_datetime, '%Y-%m-%d %H:%M:%S'))
         return False
 
-    def get(self, cr, uid, name, model, res_id=False, context={}):
+    def get(self, cr, uid, name, model, res_id=False, context=None):
         domain = self._get_domain(cr, uid, name, model, context=context)
         if domain is not None:
             domain = [('res_id', '=', res_id)] + domain

=== modified file 'openerp/addons/base/res/res_bank.py'
--- openerp/addons/base/res/res_bank.py	2011-10-11 08:03:38 +0000
+++ openerp/addons/base/res/res_bank.py	2011-11-07 15:51:24 +0000
@@ -190,7 +190,7 @@
             res.append((val.id, result))
         return res
 
-    def onchange_company_id(self, cr, uid, ids, company_id, context={}):
+    def onchange_company_id(self, cr, uid, ids, company_id, context=None):
         result = {}
         if company_id:
             c = self.pool.get('res.company').browse(cr, uid, company_id, context=context)
@@ -201,7 +201,7 @@
                 result = r
         return result
 
-    def onchange_bank_id(self, cr, uid, ids, bank_id, context={}):
+    def onchange_bank_id(self, cr, uid, ids, bank_id, context=None):
         result = {}
         if bank_id:
             bank = self.pool.get('res.bank').browse(cr, uid, bank_id, context=context)
@@ -210,7 +210,7 @@
         return {'value': result}
 
 
-    def onchange_partner_id(self, cr, uid, id, partner_id, context={}):
+    def onchange_partner_id(self, cr, uid, id, partner_id, context=None):
         result = {}
         if partner_id:
             part = self.pool.get('res.partner').browse(cr, uid, partner_id, context=context)

=== modified file 'openerp/addons/base/res/res_company.py'
--- openerp/addons/base/res/res_company.py	2011-09-30 08:12:35 +0000
+++ openerp/addons/base/res/res_company.py	2011-11-07 15:51:24 +0000
@@ -148,7 +148,7 @@
     _sql_constraints = [
         ('name_uniq', 'unique (name)', 'The company name must be unique !')
     ]
-    def on_change_header(self, cr, uid, ids, phone, email, fax, website, vat, reg=False, context={}):
+    def on_change_header(self, cr, uid, ids, phone, email, fax, website, vat, reg=False, context=None):
         val = []
         if phone: val.append(_('Phone: ')+phone)
         if fax: val.append(_('Fax: ')+fax)
@@ -201,7 +201,7 @@
         ids =  self.search(cr, uid, [('parent_id','child_of',[company])])
         return ids
 
-    def _get_partner_hierarchy(self, cr, uid, company_id, context={}):
+    def _get_partner_hierarchy(self, cr, uid, company_id, context=None):
         if company_id:
             parent_id = self.browse(cr, uid, company_id)['parent_id']
             if parent_id:
@@ -210,7 +210,7 @@
                 return self._get_partner_descendance(cr, uid, company_id, [], context)
         return []
 
-    def _get_partner_descendance(self, cr, uid, company_id, descendance, context={}):
+    def _get_partner_descendance(self, cr, uid, company_id, descendance, context=None):
         descendance.append(self.browse(cr, uid, company_id).partner_id.id)
         for child_id in self._get_company_children(cr, uid, company_id):
             if child_id != company_id:
@@ -239,7 +239,7 @@
         self.cache_restart(cr)
         return super(res_company, self).write(cr, *args, **argv)
 
-    def _get_euro(self, cr, uid, context={}):
+    def _get_euro(self, cr, uid, context=None):
         try:
             return self.pool.get('res.currency').search(cr, uid, [])[0]
         except:

=== modified file 'openerp/addons/base/res/res_lang.py'
--- openerp/addons/base/res/res_lang.py	2011-09-13 14:46:00 +0000
+++ openerp/addons/base/res/res_lang.py	2011-11-07 15:51:24 +0000
@@ -125,10 +125,10 @@
                     return False
         return True
 
-    def _get_default_date_format(self,cursor,user,context={}):
+    def _get_default_date_format(self, cursor, user, context=None):
         return '%m/%d/%Y'
 
-    def _get_default_time_format(self,cursor,user,context={}):
+    def _get_default_time_format(self, cursor, user, context=None):
         return '%H:%M:%S'
 
     _columns = {

=== modified file 'openerp/addons/base/res/res_log.py'
--- openerp/addons/base/res/res_log.py	2010-12-08 17:03:50 +0000
+++ openerp/addons/base/res/res_log.py	2011-11-07 15:51:24 +0000
@@ -41,7 +41,7 @@
     _order='create_date desc'
 
     _index_name = 'res_log_uid_read'
-    def _auto_init(self, cr, context={}):
+    def _auto_init(self, cr, context=None):
         super(res_log, self)._auto_init(cr, context)
         cr.execute('SELECT 1 FROM pg_indexes WHERE indexname=%s',
                    (self._index_name,))

=== modified file 'openerp/addons/base/res/res_partner.py'
--- openerp/addons/base/res/res_partner.py	2011-10-11 16:34:35 +0000
+++ openerp/addons/base/res/res_partner.py	2011-11-07 15:51:24 +0000
@@ -98,7 +98,7 @@
     _order = 'name'
 res_partner_title()
 
-def _lang_get(self, cr, uid, context={}):
+def _lang_get(self, cr, uid, context=None):
     obj = self.pool.get('res.lang')
     ids = obj.search(cr, uid, [], context=context)
     res = obj.read(cr, uid, ids, ['code', 'name'], context)
@@ -142,7 +142,9 @@
         'color': fields.integer('Color Index'),
     }
 
-    def _default_category(self, cr, uid, context={}):
+    def _default_category(self, cr, uid, context=None):
+        if context is None:
+            context = {}
         if 'category_id' in context and context['category_id']:
             return [context['category_id']]
         return []
@@ -156,7 +158,9 @@
         'color': 0,
     }
 
-    def copy(self, cr, uid, id, default={}, context={}):
+    def copy(self, cr, uid, id, default=None, context=None):
+        if default is None:
+            default = {}
         name = self.read(cr, uid, [id], ['name'])[0]['name']
         default.update({'name': name+ _(' (copy)'), 'events':[]})
         return super(res_partner, self).copy(cr, uid, id, default, context)
@@ -182,10 +186,12 @@
 
 #   _constraints = [(_check_ean_key, 'Error: Invalid ean code', ['ean13'])]
 
-    def name_get(self, cr, uid, ids, context={}):
+    def name_get(self, cr, uid, ids, context=None):
+        if context is None:
+            context = {}
         if not len(ids):
             return []
-        if context and context.get('show_ref'):
+        if context.get('show_ref', False):
             rec_name = 'ref'
         else:
             rec_name = 'name'
@@ -224,7 +230,9 @@
             ids = ids[16:]
         return True
 
-    def address_get(self, cr, uid, ids, adr_pref=['default']):
+    def address_get(self, cr, uid, ids, adr_pref=None):
+        if adr_pref is None:
+            adr_pref = ['default']
         address_obj = self.pool.get('res.partner.address')
         address_ids = address_obj.search(cr, uid, [('partner_id', 'in', ids)])
         address_rec = address_obj.read(cr, uid, address_ids, ['type'])
@@ -308,7 +316,7 @@
         'company_id': lambda s,cr,uid,c: s.pool.get('res.company')._company_default_get(cr, uid, 'res.partner.address', context=c),
     }
 
-    def name_get(self, cr, user, ids, context={}):
+    def name_get(self, cr, user, ids, context=None):
         if context is None:
             context = {}
         if not len(ids):

=== modified file 'openerp/addons/base/res/res_request.py'
--- openerp/addons/base/res/res_request.py	2011-01-11 05:08:59 +0000
+++ openerp/addons/base/res/res_request.py	2011-11-07 15:51:24 +0000
@@ -22,7 +22,7 @@
 from osv import osv, fields
 import time
 
-def _links_get(self, cr, uid, context={}):
+def _links_get(self, cr, uid, context=None):
     obj = self.pool.get('res.request.link')
     ids = obj.search(cr, uid, [])
     res = obj.read(cr, uid, ids, ['object', 'name'], context)

=== modified file 'openerp/report/render/rml2html/utils.py'
--- openerp/report/render/rml2html/utils.py	2009-10-20 10:52:23 +0000
+++ openerp/report/render/rml2html/utils.py	2011-11-07 15:51:24 +0000
@@ -48,7 +48,9 @@
 def bool_get(value):
     return (str(value)=="1") or (value.lower()=='yes')
 
-def attr_get(node, attrs, dict={}):
+def attr_get(node, attrs, dict=None):
+    if dict is None:
+        dict = {}
     res = {}
     for name in attrs:
         if node.get(name):

=== modified file 'openerp/report/render/rml2pdf/trml2pdf.py'
--- openerp/report/render/rml2pdf/trml2pdf.py	2011-11-04 15:57:59 +0000
+++ openerp/report/render/rml2pdf/trml2pdf.py	2011-11-07 15:51:24 +0000
@@ -226,7 +226,9 @@
         return style
 
 class _rml_doc(object):
-    def __init__(self, node, localcontext, images={}, path='.', title=None):
+    def __init__(self, node, localcontext, images=None, path='.', title=None):
+        if images is None:
+            images = {}
         self.localcontext = localcontext
         self.etree = node
         self.filename = self.etree.get('filename')
@@ -311,7 +313,9 @@
             self.canvas.save()
 
 class _rml_canvas(object):
-    def __init__(self, canvas, localcontext, doc_tmpl=None, doc=None, images={}, path='.', title=None):
+    def __init__(self, canvas, localcontext, doc_tmpl=None, doc=None, images=None, path='.', title=None):
+        if images is None:
+            images = {}
         self.localcontext = localcontext
         self.canvas = canvas
         self.styles = doc.styles
@@ -564,7 +568,9 @@
                 tags[n.tag](n)
 
 class _rml_draw(object):
-    def __init__(self, localcontext ,node, styles, images={}, path='.', title=None):
+    def __init__(self, localcontext, node, styles, images=None, path='.', title=None):
+        if images is None:
+            images = {}
         self.localcontext = localcontext
         self.node = node
         self.styles = styles
@@ -595,10 +601,12 @@
 
 class _rml_flowable(object):
     def __init__(self, doc, localcontext, images=None, path='.', title=None):
+        if images is None:
+            images = {}
         self.localcontext = localcontext
         self.doc = doc
         self.styles = doc.styles
-        self.images = images or {}
+        self.images = images
         self.path = path
         self.title = title
         self._logger = logging.getLogger('report.rml.flowable')
@@ -890,7 +898,9 @@
             self.canv._pageNumber = 0
 
 class _rml_template(object):
-    def __init__(self, localcontext, out, node, doc, images={}, path='.', title=None):
+    def __init__(self, localcontext, out, node, doc, images=None, path='.', title=None):
+        if images is None:
+            images = {}
         if not localcontext:
             localcontext={'internal_header':True}
         self.localcontext = localcontext
@@ -951,12 +961,12 @@
             fis.append(PageCount())
             self.doc_tmpl.build(fis)
 
-def parseNode(rml, localcontext=None,fout=None, images=None, path='.',title=None):
-    node = etree.XML(rml)
+def parseNode(rml, localcontext=None, fout=None, images=None, path='.', title=None):
     if localcontext is None:
         localcontext = {}
     if images is None:
         images = {}
+    node = etree.XML(rml)
     r = _rml_doc(node, localcontext, images, path, title=title)
     #try to override some font mappings
     try:
@@ -972,7 +982,11 @@
     r.render(fp)
     return fp.getvalue()
 
-def parseString(rml, localcontext = {},fout=None, images={}, path='.',title=None):
+def parseString(rml, localcontext=None, fout=None, images=None, path='.', title=None):
+    if localcontext is None:
+        localcontext = {}
+    if images is None:
+        images = {}
     node = etree.XML(rml)
     r = _rml_doc(node, localcontext, images, path, title=title)
 

=== modified file 'openerp/report/render/rml2pdf/utils.py'
--- openerp/report/render/rml2pdf/utils.py	2011-11-04 16:42:22 +0000
+++ openerp/report/render/rml2pdf/utils.py	2011-11-07 15:51:24 +0000
@@ -179,7 +179,9 @@
 def bool_get(value):
     return (str(value)=="1") or (value.lower()=='yes')
 
-def attr_get(node, attrs, dict={}):
+def attr_get(node, attrs, dict=None):
+    if dict is None:
+        dict = {}
     res = {}
     for name in attrs:
         if node.get(name):

=== modified file 'openerp/report/render/rml2txt/rml2txt.py'
--- openerp/report/render/rml2txt/rml2txt.py	2011-07-31 14:09:54 +0000
+++ openerp/report/render/rml2txt/rml2txt.py	2011-11-07 15:51:24 +0000
@@ -375,7 +375,7 @@
         return ';'.join(['%s:%s' % (x[0],x[1]) for x in self.style[tag].items()])
 
 class _rml_template(object):
-    def __init__(self, localcontext, out, node, doc, images={}, path='.', title=None):
+    def __init__(self, localcontext, out, node, doc, images=None, path='.', title=None):
         self.localcontext = localcontext
         self.frame_pos = -1
         self.frames = []
@@ -465,7 +465,7 @@
         return result
 
 class _rml_doc(object):
-    def __init__(self, node, localcontext, images={}, path='.', title=None):
+    def __init__(self, node, localcontext, images=None, path='.', title=None):
         self.localcontext = localcontext
         self.etree = node
         self.filename = self.etree.get('filename')
@@ -495,14 +495,18 @@
         self.result += '\n'
         out.write( self.result)
 
-def parseNode(rml, localcontext = {},fout=None, images={}, path='.',title=None):
+def parseNode(rml, localcontext = {},fout=None, images=None, path='.',title=None):
+    if images is None:
+        images = {}
     node = etree.XML(rml)
     r = _rml_doc(node, localcontext, images, path, title=title)
     fp = StringIO.StringIO()
     r.render(fp)
     return fp.getvalue()
 
-def parseString(rml, localcontext = {},fout=None, images={}, path='.',title=None):
+def parseString(rml, localcontext = {},fout=None, images=None, path='.',title=None):
+    if images is None:
+        images = {}
     node = etree.XML(rml)
     r = _rml_doc(node, localcontext, images, path, title=title)
     if fout:

=== modified file 'openerp/report/render/rml2txt/utils.py'
--- openerp/report/render/rml2txt/utils.py	2011-02-07 12:57:23 +0000
+++ openerp/report/render/rml2txt/utils.py	2011-11-07 15:51:24 +0000
@@ -112,7 +112,9 @@
 def bool_get(value):
     return (str(value)=="1") or (value.lower()=='yes')
 
-def attr_get(node, attrs, dict={}):
+def attr_get(node, attrs, dict=None):
+    if dict is None:
+        dict = {}
     res = {}
     for name in attrs:
         if node.get(name):

=== modified file 'openerp/tools/safe_eval.py'
--- openerp/tools/safe_eval.py	2011-10-05 01:01:36 +0000
+++ openerp/tools/safe_eval.py	2011-11-07 15:51:24 +0000
@@ -212,7 +212,13 @@
             node_or_string = node_or_string.body
         return _convert(node_or_string)
 
-def _import(name, globals={}, locals={}, fromlist=[], level=-1):
+def _import(name, globals=None, locals=None, fromlist=None, level=-1):
+    if globals is None:
+        globals = {}
+    if locals is None:
+        locals = {}
+    if fromlist is None:
+        fromlist = []
     if name in _ALLOWED_MODULES:
         return __import__(name, globals, locals, level)
     raise ImportError(name)