Merge lp:~numerigraphe/openobject-addons/trunk-stock-qty-help into lp:openobject-addons

[Numérigraphe]

It is a common mistake of OpenERP users to change the quantity directly on stock moves instead of using the "process wizard".
- they often decrease the quantity and expect a back order to be created
- they don't naturally understand that they must change this quantity in order to accept a partial delivery as complete
Too make this clear I suggest to :
- rename the quantity fields to "Ordered quantity"
- add help texts
- add a warning popup when users decrease the quantity

=== modified file 'stock/stock.py'
--- stock/stock.py	2012-02-15 18:00:28 +0000
+++ stock/stock.py	2012-02-29 11:12:21 +0000
@@ -1572,10 +1572,28 @@
         'date_expected': fields.datetime('Scheduled Date', states={'done': [('readonly', True)]},required=True, select=True, help="Scheduled date for the processing of this move"),
         'product_id': fields.many2one('product.product', 'Product', required=True, select=True, domain=[('type','<>','service')],states={'done': [('readonly', True)]}),
 
-        'product_qty': fields.float('Quantity', digits_compute=dp.get_precision('Product UoM'), required=True,states={'done': [('readonly', True)]}),
+        'product_qty': fields.float('Ordered quantity', 
+             digits_compute=dp.get_precision('Product UoM'), required=True, 
+             states={'done': [('readonly', True)]},
+             help="This is the quantity of products from an inventory "
+                  "point of view. For moves in the state 'done', this is the "
+                  "quantity of products that were actually moved. For other "
+                  "moves, this is the quantity of product that is planned to "
+                  "be moved. Lowering this quantity does not generate a "
+                  "backorder. Changing this quantity on assigned moves affects "
+                  "the product reservation, and should be done with care."),
         'product_uom': fields.many2one('product.uom', 'Unit of Measure', required=True,states={'done': [('readonly', True)]}),
-        'product_uos_qty': fields.float('Quantity (UOS)', digits_compute=dp.get_precision('Product UoM'), states={'done': [('readonly', True)]}),
-        'product_uos': fields.many2one('product.uom', 'Product UOS', states={'done': [('readonly', True)]}),
+        'product_uos_qty': fields.float('Ordered quantity (UOS)',
+            digits_compute=dp.get_precision('Product UoM'),
+            states={'done': [('readonly', True)]},
+             help="This is the quantity of products from a sales or invoicing "
+                  "point of view. For moves in the state 'done', this is the "
+                  "quantity of products that were actually moved. For other "
+                  "moves, this is the quantity of product that is planned to "
+                  "be moved. Lowering this quantity does not generate a "
+                  "backorder. Changing this quantity on assigned moves affects "
+                  "the product reservation, and should be done with care."),
+        'product_uos': fields.many2one('product.uom', 'Unit of Sale', states={'done': [('readonly', True)]}),
         'product_packaging': fields.many2one('product.packaging', 'Packaging', help="It specifies attributes of packaging like type, quantity of packaging,etc."),
 
         'location_id': fields.many2one('stock.location', 'Source Location', required=True, select=True,states={'done': [('readonly', True)]}, help="Sets a location if you produce at a fixed location. This can be a partner location if you subcontract the manufacturing operations."),
@@ -1762,19 +1780,30 @@
         result = {
                   'product_uos_qty': 0.00
           }
+        warning = {}
 
         if (not product_id) or (product_qty <=0.0):
             return {'value': result}
 
         product_obj = self.pool.get('product.product')
         uos_coeff = product_obj.read(cr, uid, product_id, ['uos_coeff'])
+        
+        # Warn if the quantity was decreased 
+        for move in self.read(cr, uid, ids, ['product_qty']):
+            if product_qty < move['product_qty']:
+                warning.update({
+                   'title': _('Warning: No Back Order'),
+                   'message': _("By changing the quantity here, you accept the "
+                                "new quantity as complete: OpenERP will not "
+                                "automatically generate a Back Order.") })
+                break
 
         if product_uos and product_uom and (product_uom != product_uos):
             result['product_uos_qty'] = product_qty * uos_coeff['uos_coeff']
         else:
             result['product_uos_qty'] = product_qty
 
-        return {'value': result}
+        return {'value': result, 'warning': warning}
 
     def onchange_uos_quantity(self, cr, uid, ids, product_id, product_uos_qty,
                           product_uos, product_uom):
@@ -1788,19 +1817,29 @@
         result = {
                   'product_qty': 0.00
           }
+        warning = {}
 
         if (not product_id) or (product_uos_qty <=0.0):
             return {'value': result}
 
         product_obj = self.pool.get('product.product')
         uos_coeff = product_obj.read(cr, uid, product_id, ['uos_coeff'])
+        
+        # Warn if the quantity was decreased 
+        for move in self.read(cr, uid, ids, ['product_uos_qty']):
+            if product_uos_qty < move['product_uos_qty']:
+                warning.update({
+                   'title': _('Warning: No Back Order'),
+                   'message': _("By changing the quantity here, you accept the "
+                                "new quantity as complete: OpenERP will not "
+                                "automatically generate a Back Order.") })
+                break
 
         if product_uos and product_uom and (product_uom != product_uos):
             result['product_qty'] = product_uos_qty / uos_coeff['uos_coeff']
         else:
             result['product_qty'] = product_uos_qty
-
-        return {'value': result}
+        return {'value': result, 'warning': warning}
 
     def onchange_product_id(self, cr, uid, ids, prod_id=False, loc_id=False,
                             loc_dest_id=False, address_id=False):