Merge lp:~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls into lp:~report-print-send-core-editors/report-print-send/7.0

[Lionel Sausin - Initiatives/Numérigraphe]

Fix missing arguments in browse call which prevents user-defined defaults to be considered.

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Lionel, you can use this better form:

user = self.pool['res.users]).browse(cr, uid, uid, context=context)

Regards.

review: Needs Fixing (code review)

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

Hi Pedro,
I avoided this form on purpose because it's the first thing people break when they inherit ORM methods, and I read it's getting deprecated in v8 (not sure, can't find the reference).
Would you still like me to change it?

[Pedro Manuel Baeza (pedro.baeza)]

What is exactly been deprecated?

- About self.pool[], here it's a good explanation why it's better: http://hypered.io/blog/2013-12-30-self-pool-get/
- About (cr, uid, uid... instead of (cr, uid, [uid], the explanation is simple: ORM methods allow lists or single ids, and in this case, you save to access to 0 index of the returned one-element list.

Regards.

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

I was talking about using a single ID sorry.

[lp:~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls]

14. By Numérigraphe on 2014-04-17

[IMP] Use short notation for browse and use pool[] instead of pool.get() as suggested by Pedro Manuel Baeza

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

Changed!

[Pedro Manuel Baeza (pedro.baeza)]

Uhm, I'm not aware about that deprecation, but it can be. I always avoid single ID on read, write, and so on overrides, but I see no problem with browse method. Do you know anyone that overrides this method?

In summary, I have no hard feeling about any form, so please let it as you want.

I find this discussion very instructive :)

Regards.

review: Approve (code review)

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

About the single id thing I followed your advice.
In v8 it'll be out for read() at least according to this: https://twitter.com/RaphaelCollet/status/403095308722139136
...but we'll need to fix a whole pile of code anyway if they deprecate it, so one more won't make a difference.

[Loïc Bellier - Numérigraphe (lb-b)]

review: Approve

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

review: Approve (code review)

=== modified file 'base_report_to_printer/ir_report.py'
--- base_report_to_printer/ir_report.py	2013-10-02 12:08:48 +0000
+++ base_report_to_printer/ir_report.py	2014-04-17 16:35:03 +0000
@@ -47,7 +47,6 @@
         return options
 
     def print_direct(self, cr, uid, report_id, result, format, printer, context=None):
-        user_obj = self.pool.get('res.users')
         fd, file_name = mkstemp()
         try:
             os.write(fd, base64.decodestring(result))
@@ -85,8 +84,8 @@
 
     def behaviour(self, cr, uid, ids, context=None):
         result = {}
-        printer_obj = self.pool.get('printing.printer')
-        printing_act_obj = self.pool.get('printing.report.xml.action')
+        printer_obj = self.pool['printing.printer']
+        printing_act_obj = self.pool['printing.report.xml.action']
         # Set hardcoded default action
         default_action = 'client'
         # Retrieve system wide printer
@@ -94,9 +93,8 @@
         if default_printer:
             default_printer = printer_obj.browse(cr, uid, default_printer, context=context)
 
-
         # Retrieve user default values
-        user = self.pool.get('res.users').browse(cr, uid, context)
+        user = self.pool['res.users'].browse(cr, uid, uid, context=context)
         if user.printing_action:
             default_action = user.printing_action
         if user.printing_printer_id: