lp:~numerigraphe-team/report-print-send/7.0-no-lock-in-update-1308635-ls
If I'm not mistaken, locking in printer.
- if what we read is immutable than the value is copied and locking is unnecessary
- if it's mutable then we're getting a "reference" to the shared object, and should keep the lock until we're completely done with it
From my quick code survey, the variables seem to contain a boolean and a float so I guess no locking is needed.
update() seems to be called pretty often (all the CRUD method call it) so It may help a bit to remove the contention.
- Get this branch:
- bzr branch lp:~numerigraphe-team/report-print-send/7.0-no-lock-in-update-1308635-ls
Branch merges
- Yannick Vaucher @ Camptocamp: Needs Resubmitting (moved on github)
- Loïc Bellier - Numérigraphe (community): Abstain
-
Diff: 32 lines (+6/-11)1 file modifiedbase_report_to_printer/printing.py (+6/-11)
Related source package recipes
Related bugs
Related blueprints
Branch information
Recent revisions
- 13. By Numérigraphe
-
[IMP] remove useless locking from update(), shouldn't be needed for immutable data
- 12. By Launchpad Translations on behalf of report-print-send-core-editors
-
Launchpad automatic translations update.
- 11. By Yannick Vaucher @ Camptocamp
-
[ADD] printer_tray
This module extends module
It detects trays on printer installation plus permits to select
the paper source on which you want to print directly. - 8. By Guewen Baconnier @ Camptocamp
-
[MIGR] Set the 'installable' flags to False on addons. They should be activated when their migration is done.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
