lp:~numerigraphe-team/report-print-send/7.0-no-lock-in-update-1308635-ls

Created by Lionel Sausin - Numérigraphe on 2014-04-16 and last modified on 2014-04-16

If I'm not mistaken, locking in printer.printer.update() is not needed, and the way it's written does not protect us from concurrent changes anyway :
- if what we read is immutable than the value is copied and locking is unnecessary
- if it's mutable then we're getting a "reference" to the shared object, and should keep the lock until we're completely done with it

From my quick code survey, the variables seem to contain a boolean and a float so I guess no locking is needed.

update() seems to be called pretty often (all the CRUD method call it) so It may help a bit to remove the contention.

Get this branch:
bzr branch lp:~numerigraphe-team/report-print-send/7.0-no-lock-in-update-1308635-ls
Members of Numérigraphe can upload to this branch. Log in for directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Numérigraphe
Project:
Report - Printing and Sending
Status:
Mature

Recent revisions

13. By Numérigraphe on 2014-04-16

[IMP] remove useless locking from update(), shouldn't be needed for immutable data

12. By Launchpad Translations on behalf of report-print-send-core-editors on 2014-02-26

Launchpad automatic translations update.

11. By Yannick Vaucher @ Camptocamp on 2014-02-25

[ADD] printer_tray

This module extends module
It detects trays on printer installation plus permits to select
the paper source on which you want to print directly.

10. By Yannick Vaucher @ Camptocamp on 2013-12-27

[MRG] Simple split of code which was in a single file

9. By Yannick Vaucher @ Camptocamp on 2013-12-27

[MRG] Portage of base_report_to_printer

8. By Guewen Baconnier @ Camptocamp on 2013-03-14

[MIGR] Set the 'installable' flags to False on addons. They should be activated when their migration is done.

7. By Lorenzo Battistini on 2013-01-16

[FIX] base_report_to_printer - 'authors'

6. By gbaconnier-c2c on 2012-12-28

[FIX] pingen bug lp:1086393

5. By Omar (Pexego) on 2012-12-21

[FIX] pingen: wrong name, company_id should be company

4. By Lorenzo Battistini on 2012-12-08

[FIX] base_report_to_printer description

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:~report-print-send-core-editors/report-print-send/7.0
This branch contains Public information 
Everyone can see this information.

Subscribers