Merge lp:~numerigraphe-team/openobject-addons/6.1-analytic-entry-without-general-account into lp:openobject-addons

Proposed by Lionel Sausin - Initiatives/Numérigraphe
Status: Needs review
Proposed branch: lp:~numerigraphe-team/openobject-addons/6.1-analytic-entry-without-general-account
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
account/account_analytic_line.py (+1/-1)
To merge this branch: bzr merge lp:~numerigraphe-team/openobject-addons/6.1-analytic-entry-without-general-account
Reviewer Review Type Date Requested Status
Loïc Bellier - Numérigraphe (community) code review Approve
OpenERP Core Team Pending
Review via email: mp+210557@code.launchpad.net

This proposal supersedes a proposal from 2013-03-05.

Description of the change

I'm resubmitting this branch unchanged for inclusion in v8.

The manual for analytic accounts states[1] : "Each analytic entry can be linked to a general account, or not, as you wish. Conversely, an entry in a general account can be linked to one, several, or no corresponding analytic accounts."
But the field 'general_account_id' is defined as "required=True" in account/account_analytic_line.py
I suggest that this requirement should be relaxed to allow greater flexibility in analytic accounting.

This branch was forked off v6.1.0 but it merges cleanly into the current trunk.
I has already been accepted in the community backport v7.0 on 2013-08-21

Lionel Sausin

[1] http://doc.openerp.com/v6.1/book/4/4_10_Accounts/index.html

To post a comment you must log in.
Revision history for this message
Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) wrote : Posted in a previous version of this proposal

For your information this was approved in the community backport v7.0 on 2013-08-21 : https://code.launchpad.net/~sbi/ocb-addons/6.1-analytic-entry-without-general-account/+merge/181322

Revision history for this message
Loïc Bellier - Numérigraphe (lb-b) :
review: Approve (code review)

Unmerged revisions

6620. By Numerigraphe - Lionel Sausin <email address hidden>

[IMP] The general account is not mandatory in analytic account entries

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/account_analytic_line.py'
2--- account/account_analytic_line.py 2013-10-27 12:31:04 +0000
3+++ account/account_analytic_line.py 2014-03-12 08:59:02 +0000
4@@ -29,7 +29,7 @@
5 _columns = {
6 'product_uom_id': fields.many2one('product.uom', 'Unit of Measure'),
7 'product_id': fields.many2one('product.product', 'Product'),
8- 'general_account_id': fields.many2one('account.account', 'General Account', required=True, ondelete='restrict'),
9+ 'general_account_id': fields.many2one('account.account', 'General Account', ondelete='restrict'),
10 'move_id': fields.many2one('account.move.line', 'Move Line', ondelete='cascade', select=True),
11 'journal_id': fields.many2one('account.analytic.journal', 'Analytic Journal', required=True, ondelete='restrict', select=True),
12 'code': fields.char('Code', size=8),

Subscribers

People subscribed via source and target branches

to all changes: