Merge lp:~numerigraphe-team/openobject-addons/6.0-inventory-move-date into lp:openobject-addons/6.0

[Lionel Sausin - Initiatives/Numérigraphe]

This branch fixes the date of stock moves for inventory adjustments.
It uses the inventory's date instead of "today", which makes it consistent with the way the starting quantity is already computed.

Entering moves this way was debated at length and judged the right thing to do for v8, and is implemented in trunk-wms.

This branch runs green on runbot: http://runbot.openerp.com/numerigraphe-team-6-0-inventory-move-date-32072/logs/

[Loïc Bellier - Numérigraphe (lb-b)]

review: Approve (code review)

Unmerged revisions

5479. By Numérigraphe on 2013-06-12

[IMP] Test the date of the inventory stock moves

5478. By Numérigraphe on 2013-06-11

[FIX] write inventory stock moves at the right date

=== modified file 'stock/stock.py'
--- stock/stock.py	2012-08-17 07:46:56 +0000
+++ stock/stock.py	2014-03-28 16:52:55 +0000
@@ -2164,7 +2164,11 @@
         if todo:
             self.action_confirm(cr, uid, todo, context=context)
 
-        self.write(cr, uid, move_ids, {'state': 'done', 'date': time.strftime('%Y-%m-%d %H:%M:%S')}, context=context)
+        # Mark the move done, either now or at the datetime required by the context (ie. inventory being done)
+        self.write(cr, uid, move_ids,
+                   {'state': 'done',
+                    'date': context.get('move_date', time.strftime('%Y-%m-%d %H:%M:%S'))},
+                   context=context)
         for id in move_ids:
              wf_service.trg_trigger(uid, 'stock.move', id, cr)
 
@@ -2562,8 +2566,11 @@
         """
         if context is None:
             context = {}
+        else:
+            context=context.copy()
         move_obj = self.pool.get('stock.move')
         for inv in self.browse(cr, uid, ids, context=context):
+            context['move_date'] = inv.date
             move_obj.action_done(cr, uid, [x.id for x in inv.move_ids], context=context)
             self.write(cr, uid, [inv.id], {'state':'done', 'date_done': time.strftime('%Y-%m-%d %H:%M:%S')}, context=context)
         return True
@@ -2596,6 +2603,7 @@
                         'product_uom': line.product_uom.id,
                         'prodlot_id': lot_id,
                         'date': inv.date,
+                        'date_expected': inv.date,
                     }
                     if change > 0:
                         value.update( {

=== modified file 'stock/test/stock_test.yml'
--- stock/test/stock_test.yml	2012-10-23 11:19:09 +0000
+++ stock/test/stock_test.yml	2014-03-28 16:52:55 +0000
@@ -226,8 +226,7 @@
 -
    !record {model: stock.inventory, id: stock_inventory_physicalinventoy0}:
     company_id: base.main_company
-    date: !eval time.strftime('%Y-%m-%d %H:%M:%S')
-    date_done: !eval time.strftime('%Y-%m-%d %H:%M:%S')
+    date: '2001-01-01 00:00:00'
     inventory_line_id:
       - company_id: base.main_company
         location_id: stock.stock_location_stock
@@ -250,6 +249,13 @@
    self.action_confirm(cr,uid,[ref('stock_inventory_physicalinventoy0')])
    self.action_done(cr,uid,[ref('stock_inventory_physicalinventoy0')])
 -
+  I check that stock moves were created for this inventory, and that their date is right
+-
+  !python {model: stock.inventory}: |
+    inventories = self.browse(cr, uid, [ref('stock_inventory_physicalinventoy0')])
+    assert inventories[0].move_ids, "No stock moves were created during the initial inventory."
+    assert inventories[0].move_ids[0].date == '2001-01-01 00:00:00', "The stock moves created during the initial inventory have the wrong date."
+-
   I create stock.fill.inventory .
 -
   !record {model: stock.fill.inventory, id: stock_fill_inventory_0}: