Merge lp:~numerigraphe-team/openerp-data/7.0-fix-naf-shortname into lp:~openerp-data-editors/openerp-data/7.0

Proposed by Lionel Sausin - Initiatives/Numérigraphe
Status: Rejected
Rejected by: Lionel Sausin - Initiatives/Numérigraphe
Proposed branch: lp:~numerigraphe-team/openerp-data/7.0-fix-naf-shortname
Merge into: lp:~openerp-data-editors/openerp-data/7.0
Diff against target: 17 lines (+4/-2)
1 file modified
l10n_fr_naf_ape/partner_view.xml (+4/-2)
To merge this branch: bzr merge lp:~numerigraphe-team/openerp-data/7.0-fix-naf-shortname
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp Needs Resubmitting
Joël Grand-Guillaume @ camptocamp code review, no test Approve
Loïc Bellier - Numérigraphe (community) code review Approve
Review via email: mp+215446@code.launchpad.net

Description of the change

This change displays the short name of the NAF category on the partner form.
To do this, it forces the web client to call name_get() when it displays the NAF field on the partner form instead of relying on a context-insensitive prefetch.

To post a comment you must log in.
Revision history for this message
Loïc Bellier - Numérigraphe (lb-b) :
review: Approve (code review)
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi Lionel,

Thanks for this contribution.
LGTM

review: Approve (code review, no test)
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

Hello,

The management of the project has moved to Github: https://github.com/OCA/community-data-files

Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how to proceed.

Thanks for contributing to the project

review: Needs Resubmitting
Revision history for this message
Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) wrote :

Unmerged revisions

11. By Numérigraphe

[FIX] Force the web client to call name_get() on NAF categories instead of relying on search/read

10. By Numérigraphe

[IMP] Place the NAF field next on the left side of the view

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'l10n_fr_naf_ape/partner_view.xml'
2--- l10n_fr_naf_ape/partner_view.xml 2014-03-25 17:31:32 +0000
3+++ l10n_fr_naf_ape/partner_view.xml 2014-04-11 15:36:51 +0000
4@@ -7,9 +7,11 @@
5 <field name="model">res.partner</field>
6 <field name="inherit_id" ref="base.view_partner_form" />
7 <field name="arch" type="xml">
8- <field name="title" position="after">
9+ <field name="website" position="after">
10 <field name="ape_id" context="{'partner_category_display': 'short'}"
11- domain="[('parent_id', 'child_of', %(l10n_eu_nace.nace_root)d)]"/>
12+ attrs="{'invisible': [('is_company', '=', False)]}"
13+ domain="[('parent_id', 'child_of', %(l10n_eu_nace.nace_root)d)]"
14+ options='{"always_reload": True}'/>
15 </field>
16 </field>
17 </record>

Subscribers

People subscribed via source and target branches