Merge lp:~numerigraphe-team/openerp-addons/7.0-hide-oe_view_only into lp:ocb-web

[Lionel Sausin - Initiatives/Numérigraphe]

This patch written by Daniel Hammerschmidt makes the style "oe_view_only" hide contents in "edit mode", in a way similar to "oe_edit_only" hiding them in "view only" mode.
It is not a bugfix but an small improvement, but even though I'm new to the web client code this looks pretty harmless.

This branch runs green on Runbot : http://runbot.openerp.com/numerigraphe-team-7-0-hide-oe-view-only-31943/logs/

[Stefan Rijnhart (Opener) (stefan-opener)]

Hi Lionel,

this is a good improvement, as I commented on the bug report a year ago. However, if we put this feature in OCB, then we may get community modules depending on this feature, thus on OCB. The general attitude is that that is a bad thing for OCB.

Looks like this change translates into an equally short snippet that can easily be put in a separate community module, or even included in the modules that intend to use this functionality. So I dissapprove of having this in OCB. You may however, check the situation for trunk and propose there on the OpenERP branch so that we can all enjoy this in the next edition.

On a technical level, OpenERP 7.0 css is maintained in the sass file which you find in static/src/css, and then compiled to css. Sass files are compiled using a ruby package by the same name.

review: Disapprove

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

Thanks for your review, it makes perfect sense. I'll move the patch to sass and try to get it adopted upstream.

Unmerged revisions

4166. By Daniel Hammerschmidt on 2014-03-26

[IMP] Hide oe_view_only style when not in edit mode

=== modified file 'addons/web/static/src/css/base.css'
--- addons/web/static/src/css/base.css	2014-02-13 14:57:55 +0000
+++ addons/web/static/src/css/base.css	2014-03-26 22:06:44 +0000
@@ -2116,7 +2116,8 @@
 .openerp .oe_form_invisible {
   display: none !important;
 }
-.openerp .oe_form_readonly .oe_edit_only, .openerp .oe_form_readonly .oe_form_field:empty {
+.openerp .oe_form_readonly .oe_edit_only, .openerp .oe_form_readonly .oe_form_field:empty,
+.openerp .oe_form_editable .oe_view_only {
   display: none !important;
 }
 .openerp .oe_form_readonly .oe_form .oe_form_field_date {