Merge lp:~numerigraphe-team/ocb-addons/7.0-filter-zero-inventory-analysis into lp:ocb-addons

Proposed by Lionel Sausin - Initiatives/Numérigraphe
Status: Work in progress
Proposed branch: lp:~numerigraphe-team/ocb-addons/7.0-filter-zero-inventory-analysis
Merge into: lp:ocb-addons
Diff against target: 24 lines (+5/-2)
1 file modified
stock/report/report_stock_move_view.xml (+5/-2)
To merge this branch: bzr merge lp:~numerigraphe-team/ocb-addons/7.0-filter-zero-inventory-analysis
Reviewer Review Type Date Requested Status
Raphaël Valyi - http://www.akretion.com Needs Information
Alexandre Fayolle - camptocamp Needs Fixing
Holger Brunn (Therp) code review Approve
Review via email: mp+210216@code.launchpad.net

This proposal supersedes a proposal from 2014-03-07.

Description of the change

This branch adds 3 filters to the inventory analysis : available products, products out of stock, the products with negative stock
The branch targets v7.0 and another fix should be developed upstream in the new WMS code for v8.

To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote : Posted in a previous version of this proposal

The help texts seem a bit weird to me. How about

'Products with available quantity greater than zero'

etc.?

review: Needs Fixing (code review)
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM, but the corresponding MP on official addons is missing.

review: Needs Fixing
Revision history for this message
Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) wrote :

I'm not making an MP for v7.0 because it's an improvement rather than a bugfix.
I think I remember this was factored in in tunk-wms but I'll check again. If it isn't I'll withdraw this proposal and manage the branch on my own.

Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

I like the improvement, but before approving, I would like to read an explanation what it becomes in v8 as I couldn't even find a report.stock.inventory on trunk-wms.

review: Needs Information

Unmerged revisions

8592. By Numérigraphe

[IMP] simplify wording of help texts

8591. By Numérigraphe

[IMP] Add search filters for products available, out of stock, and with negative stock in inventory analysis

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'stock/report/report_stock_move_view.xml'
2--- stock/report/report_stock_move_view.xml 2012-10-23 16:05:04 +0000
3+++ stock/report/report_stock_move_view.xml 2014-03-10 14:35:42 +0000
4@@ -139,6 +139,10 @@
5 <field name="model">report.stock.inventory</field>
6 <field name="arch" type="xml">
7 <search string="Inventory Analysis">
8+ <filter string="Available" name="available" help="Products with Available Quantity greater than zero" icon="terp-accessories-archiver" domain="[('product_qty','&gt;',0.0)]"/>
9+ <filter string="Out of Stock" name="unavailable" help="Products with Available Quantity equal to zero" icon="terp-dialog-close" domain="[('product_qty','=',0.0)]"/>
10+ <filter string="Negative Stock" name="negative_stock" icon="terp-emblem-important" help="Products with Available Quantity lower than zero" domain="[('product_qty','&lt;',0.0)]"/>
11+ <separator orientation="vertical"/>
12 <filter string="Real" name="real" icon="terp-check" domain="[('state','=','done')]"
13 help="Analysis of current inventory (only moves that have already been processed)"/>
14 <filter string="Future" icon="terp-stock" domain="[('state','in',('assigned','done','waiting','confirmed'))]"
15@@ -179,8 +183,7 @@
16 <field name="view_type">form</field>
17 <field name="view_mode">tree,graph</field>
18 <field name="search_view_id" eval="False"/>
19- <field name="context">{'contact_display': 'partner', 'search_default_real':1,
20-'search_default_year':1,'search_default_month':1, 'search_default_location_type_internal':1,'search_default_group_product':1,'group_by':[], 'group_by_no_leaf':1}</field>
21+ <field name="context">{'contact_display': 'partner', 'search_default_real':1, 'search_default_year':1,'search_default_month':1, 'search_default_location_type_internal':1, 'search_default_group_product':1, 'search_default_available':1, 'group_by':[], 'group_by_no_leaf':1}</field>
22 <field name="help">Inventory Analysis allows you to easily check and analyse your company stock levels. Sort and group by selection criteria in order to better analyse and manage your company activities.</field>
23 </record>
24 <menuitem action="action_stock_inventory_report"