Merge lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into lp:ocb-addons
Proposed by
Lionel Sausin - Initiatives/Numérigraphe
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo | ||||
Merge into: | lp:ocb-addons | ||||
Diff against target: |
12 lines (+1/-1) 1 file modified
procurement/procurement.py (+1/-1) |
||||
To merge this branch: | bzr merge lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Valyi - http://www.akretion.com | Approve | ||
Leonardo Pistone | code review | Approve | |
Alexandre Fayolle - camptocamp | code review, no test | Needs Information | |
Holger Brunn (Therp) | code review | Approve | |
Pedro Manuel Baeza | code review | Approve | |
Stefan Rijnhart (Opener) | Approve | ||
Guewen Baconnier @ Camptocamp | Pending | ||
Lionel Sausin - Initiatives/Numérigraphe | Pending | ||
Review via email: mp+209917@code.launchpad.net |
This proposal supersedes a proposal from 2014-03-07.
This proposal has been superseded by a proposal from 2014-03-18.
Description of the change
This fixes a bug where the MRP scheduler fails when messages are too long to be stored in the database (particularly if the locale strings are verbose).
The length constraint is removed altogether as proposed by Guewen Baconnier.
To post a comment you must log in.
The size argument could be entirely removed, it is no longer required since the version 7.0.
It should be used when there is a reason to restrict the length of a field (e.g. ean13), there is no reason to do so here (varchar and text are the same thing under the hood, so the limitation won't bring better performance [0]).
For the record, here is the MP on the OpenERP's branch: /code.launchpad .net/~openerp- dev/openobject- addons/ trunk-bug- 1079548- sgo/+merge/ 137482
https:/
Thanks
[0] http:// stackoverflow. com/questions/ 4848964/ postgresql- difference- between- text-and- varchar- character- varying