Merge lp:~nuclearbob/utah/remove-report-check into lp:utah

[Max Brustkern]

Per an IRC conversation, I've commented out the test for report.html in the iso static validation, since it has outlived its usefulness.

[Javier Collado (javier.collado)]

I don't like much to have commented code when there's version control.

If there's no longer a reason to have the test, then it can be removed. If it
will useful when some other thing is fixed, then it can be decorated with
unittest.skip and a message about what's the reason why the test case is being
temporarily skipped.

[lp:~nuclearbob/utah/remove-report-check]

760. By Max Brustkern on 2012-11-27

Removed test since history will be in version control

[Max Brustkern (nuclearbob)]

You make a good point. If we ever do want that code again for some reason, it's in the history.

review: Needs Resubmitting

[Javier Collado (javier.collado)]

Looks nice now. Thanks.

review: Approve

=== modified file 'utah/isotest/iso_static_validation.py'
--- utah/isotest/iso_static_validation.py	2012-11-16 19:27:27 +0000
+++ utah/isotest/iso_static_validation.py	2012-11-27 18:13:23 +0000
@@ -380,23 +380,6 @@
         self.assertEqual(stderr, '')
         self.assertIn("created 1 directories", stdout)
 
-    # Test if the report.html exists for the d-i based images
-    # and that it does not have any conflicting packages
-    @unittest.skipIf(ubiquity_image, "Skipping for ubiquity based images")
-    def test_report_html(self):
-        report_url = os.path.join(self.url, 'current', 'report.html')
-        try:
-            fh_report_page = urllib2.urlopen(report_url).read()
-        except urllib2.HTTPError, e:
-            logging.error("Failed to fetch URL '%s': %s .", report_url, e)
-            self.fail("Failed to fetch report.html from  the server")
-
-        # check the number of failed packages
-        report_page_lines = re.findall('there were ["]?([^" >]+)',
-                                       fh_report_page)
-        logging.debug('Check for conflicting packages in the report file')
-        self.assertEqual(['0'], report_page_lines)
-
     # clean up
     @classmethod
     def tearDownClass(cls):