Merge lp:~nuclearbob/utah/deprecate-runscripts into lp:utah

[Max Brustkern]

I'd like to get rid of the other runscripts so we don't keep having to change them. I don't think they're currently in use, but I'd like to do a release with a deprecation warning before actually dropping them.

[Javier Collado (javier.collado)]

I think this is a good idea.

In case someone relies on any of the scripts, it would be nice to have an
example about how to translate the call to a given script to run_utah_tests.py.

[Andy Doan (doanac)]

I like Javier's idea, not sure how easy that would be to do. Also - most of these jobs are run by a machine, so I'm not sure how much attention human's will pay to this warning?

review: Approve

[lp:~nuclearbob/utah/deprecate-runscripts]

856. By Max Brustkern on 2013-04-10

Updated run scripts with individual transition plans

857. By Max Brustkern on 2013-04-10

Updated changelog

[Max Brustkern (nuclearbob)]

I added stuff specific to each script and updated the changelog.

review: Needs Resubmitting

[Javier Collado (javier.collado)]

Looks good to me now. Thanks.

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2013-04-04 14:58:12 +0000
+++ debian/changelog	2013-04-10 15:14:20 +0000
@@ -1,3 +1,9 @@
+utah (0.10ubuntu2) quantal; urgency=low
+
+  * Deprecated run scripts
+
+ -- Max Brustkern <[e-mail]>  Wed, 10 Apr 2013 11:06:41 -0400
+
 utah (0.10ubuntu1) UNRELEASED; urgency=low
 
   * Return error code on unhandled error (LP: #1160857)

=== modified file 'examples/run_install_test.py'
--- examples/run_install_test.py	2013-04-03 14:25:21 +0000
+++ examples/run_install_test.py	2013-04-10 15:14:20 +0000
@@ -107,6 +107,11 @@
 
 
 if __name__ == '__main__':
+    logging.warning('This script is deprecated; please use run_utah_tests.py')
+    logging.warning('The same command line arguments should work there, i.e.:')
+    argv = list(sys.argv)
+    argv[0] = 'run_utah_tests.py'
+    logging.warning(' '.join(argv))
     try:
         run_install_test()
     finally:

=== modified file 'examples/run_test_bamboo_feeder.py'
--- examples/run_test_bamboo_feeder.py	2013-04-03 14:25:21 +0000
+++ examples/run_test_bamboo_feeder.py	2013-04-10 15:14:20 +0000
@@ -107,6 +107,9 @@
 
 
 if __name__ == '__main__':
+    logging.warning('This script is thought to be broken')
+    logging.warning('If it is working, please report it to the UTAH team via '
+                    '[e-mail]')
     try:
         run_test_bamboo_feeder()
     finally:

=== modified file 'examples/run_test_cobbler.py'
--- examples/run_test_cobbler.py	2013-04-03 14:25:21 +0000
+++ examples/run_test_cobbler.py	2013-04-10 15:14:20 +0000
@@ -112,6 +112,12 @@
 
 
 if __name__ == '__main__':
+    logging.warning('This script is deprecated; please use run_utah_tests.py')
+    logging.warning('Add the -m physical argument to your existing list, i.e.:')
+    argv = list(sys.argv)
+    argv[0] = 'run_utah_tests.py'
+    argv.extend(['-m', 'physical'])
+    logging.warning(' '.join(argv))
     try:
         run_test_cobbler()
     finally:

=== modified file 'examples/run_test_vm.py'
--- examples/run_test_vm.py	2013-04-03 14:25:21 +0000
+++ examples/run_test_vm.py	2013-04-10 15:14:20 +0000
@@ -101,6 +101,11 @@
 
 
 if __name__ == '__main__':
+    logging.warning('This script is deprecated; please use run_utah_tests.py')
+    logging.warning('The same command line arguments should work there, i.e.:')
+    argv = list(sys.argv)
+    argv[0] = 'run_utah_tests.py'
+    logging.warning(' '.join(argv))
     try:
         run_test_vm()
     finally: