UTAH

Merge lp:~nuclearbob/utah/debian-frontend into lp:utah

  1. debian-frontend
  2. Merge into dev
Proposed by Max Brustkern
Status: Merged
Merged at revision: 799
Proposed branch: lp:~nuclearbob/utah/debian-frontend
Merge into: lp:utah
Diff against target: 18 lines (+1/-2)
1 file modified
utah/provisioning/provisioning.py (+1/-2)
To merge this branch: bzr merge lp:~nuclearbob/utah/debian-frontend
Reviewer Review Type Date Requested Status
Javier Collado (community) Approve
Review via email: mp+142153@code.launchpad.net

Description of the change

This branch moves the line to set the DEBIAN_FRONTEND environment variable to the gdebi command instead of having it run before commands that don't use it.

To post a comment you must log in.
Revision history for this message
Javier Collado (javier.collado) wrote :

Makes sense, thanks!

(tested successfully with the pass.run runlist)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utah/provisioning/provisioning.py'
2--- utah/provisioning/provisioning.py 2013-01-07 10:25:48 +0000
3+++ utah/provisioning/provisioning.py 2013-01-07 16:38:47 +0000
4@@ -405,13 +405,12 @@
5
6 remote_deb = os.path.join(tmppath, os.path.basename(deb))
7 install_command = (
8- 'DEBIAN_FRONTEND=noninteractive; '
9 'while (fuser /var/lib/dpkg/lock >/dev/null 2>&1); '
10 'do '
11 'echo "Waiting for dpkg lock to become available"; '
12 'sleep 10; '
13 'done ; '
14- 'gdebi -n -q {}'
15+ 'DEBIAN_FRONTEND=noninteractive gdebi -n -q {}'
16 .format(remote_deb))
17 returncode, _stdout, stderr = self.run(install_command, root=True)
18 if (returncode != 0 or

Subscribers

People subscribed via source and target branches