Merge lp:~nuclearbob/utah/cobbler-cleanup into lp:utah
Proposed by
Max Brustkern
Status: | Merged |
---|---|
Approved by: | Javier Collado |
Approved revision: | 705 |
Merged at revision: | 705 |
Proposed branch: | lp:~nuclearbob/utah/cobbler-cleanup |
Merge into: | lp:utah |
Diff against target: |
62 lines (+20/-13) 1 file modified
utah/provisioning/baremetal/cobbler.py (+20/-13) |
To merge this branch: | bzr merge lp:~nuclearbob/utah/cobbler-cleanup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Javier Collado (community) | Approve | ||
Max Brustkern (community) | Needs Resubmitting | ||
Review via email: mp+128792@code.launchpad.net |
Description of the change
This branch should more aggressively clean up tmp directories in case of failures so we don't get left with tons of directories cluttering up the system.
To post a comment you must log in.
I think that in the _cleanuptmpdir method is confusing to use a variable
that is named `filename` when it could be both a filename or a dirname.
I'd prefer something like `name`, but since that's already used in the
loop for the relative name, maybe `absolute_name` is a good choice
(also `path`, `absolute_path` might be good alternatives).