UTAH

Merge lp:~nuclearbob/utah/bug1112597 into lp:utah

  1. bug1112597
  2. Merge into dev
Proposed by Max Brustkern
Status: Merged
Approved by: Javier Collado
Approved revision: 878
Merged at revision: 877
Proposed branch: lp:~nuclearbob/utah/bug1112597
Merge into: lp:utah
Diff against target: 31 lines (+4/-4)
2 files modified
debian/changelog (+2/-1)
examples/run_utah_tests.py (+2/-3)
To merge this branch: bzr merge lp:~nuclearbob/utah/bug1112597
Reviewer Review Type Date Requested Status
Javier Collado (community) Approve
Max Brustkern (community) Needs Resubmitting
Andy Doan (community) Approve
Review via email: mp+160764@code.launchpad.net

Description of the change

This branch fixes a small bug I noticed with the current help for run_utah_tests.py

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) :
review: Approve
Revision history for this message
Javier Collado (javier.collado) wrote :

Please fix also the the help message where it says:
"and run the two given runlists".

review: Needs Fixing
lp:~nuclearbob/utah/bug1112597 updated
877. By Max Brustkern

Fixed the other multi-runlist reference per Javier

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Good catch. Should be fixed now.

review: Needs Resubmitting
Revision history for this message
Javier Collado (javier.collado) wrote :

I think that the changelog entry should be more descriptive and use the same
format for the bug number as in other entries for consistency.

Something like this would be good enough:
Fixed help output to use just one runlist (LP: #1112597)

lp:~nuclearbob/utah/bug1112597 updated
878. By Max Brustkern

Corrected changelog

Revision history for this message
Max Brustkern (nuclearbob) wrote :

That was a silly bit of inconsistency on my part. Should be fixed now.

review: Needs Resubmitting
Revision history for this message
Javier Collado (javier.collado) wrote :

Looks good now. Thanks for the update

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-19 19:08:00 +0000
3+++ debian/changelog 2013-04-26 12:31:27 +0000
4@@ -12,8 +12,9 @@
5 * Added syslog output (including real time test output) to client
6 * Make rsyslog timeout error message clearer (LP: #1169846)
7 * Write to log UTAH version as soon as possible (LP: #1152216)
8+ * Fixed help output to use just one runlist (LP: #1112597)
9
10- -- Max Brustkern <max@canonical.com> Tue, 16 Apr 2013 09:21:19 -0400
11+ -- Max Brustkern <max@canonical.com> Wed, 24 Apr 2013 17:04:27 -0400
12
13 utah (0.10ubuntu1) UNRELEASED; urgency=low
14
15
16=== modified file 'examples/run_utah_tests.py'
17--- examples/run_utah_tests.py 2013-04-24 11:37:21 +0000
18+++ examples/run_utah_tests.py 2013-04-26 12:31:27 +0000
19@@ -51,10 +51,9 @@
20 'depending on the parameters passed.'),
21 epilog=("For example:\n"
22 "Provision a VM using a precise server image "
23- "with i386 architecture and run the two given runlists\n"
24+ "with i386 architecture and run the given runlist\n"
25 "\t%(prog)s -s precise -t server -a i386 \\\n"
26- "\t\t/usr/share/utah/client/examples/master.run \\\n"
27- "\t\t'http://people.canonical.com/~max/max_test.run'"),
28+ "\t\t/usr/share/utah/client/examples/master.run"),
29 formatter_class=argparse.RawDescriptionHelpFormatter)
30 parser.add_argument('-m', '--machinetype', metavar='MACHINETYPE',
31 choices=('physical', 'virtual'),

Subscribers

People subscribed via source and target branches