Merge lp:~nuclearbob/utah/bug1082171 into lp:utah

[Max Brustkern]

I've been unable to recreate the issue in lp:1082171 outside of the lab so far. This is the code I've been using to test it. Since it's just some additional logging, I'd like to consider merging it into the dev branch so we can see the output on all the normal smoke test jobs that are running.

[Javier Collado (javier.collado)]

Please find below some comments:

- Looks like the newly imported `time` module isn't being used anywhere.
- The `pass` statement in line 37 (438 in the source file) should be removed.

Isn't really part of this merge, but this line caught my eye:
while vm.isActive() is not 0:

- What is the set of valid output values of vm.isActive? Could "is not 0" be
  dropped?
- How long does it take vm.isActive to return a value? Could that cause that
  lots of log lines are printed to stderr?

Regarding the intended usage of this code. My understanding is that it will be
removed once the bug is fixed, so isn't something that we want to have in final
code. In such a case, while you're troubleshooting the problem, I think it
would be better to temporarily disable the jobs that update the packages in the
testing hardware and manually modify the installed .py files there. What do you
think about this?

review: Needs Fixing

[Max Brustkern (nuclearbob)]

We've got improved SSH logging, and we're working on improved installer logging elsewhere, so I think we should reject this proposal.

review: Disapprove

Unmerged revisions

794. By Max Brustkern on 2013-01-07

Writing log file size periodically to debug

=== modified file 'utah/provisioning/vm/vm.py'
--- utah/provisioning/vm/vm.py	2012-12-17 19:55:15 +0000
+++ utah/provisioning/vm/vm.py	2013-01-07 14:06:26 +0000
@@ -24,6 +24,7 @@
 import shutil
 import string
 import tempfile
+import time
 
 from xml.etree import ElementTree
 
@@ -401,8 +402,8 @@
         serial = ElementTree.Element('serial')
         serial.set('type', 'file')
         source = ElementTree.Element('source')
-        log_filename = os.path.join(config.logpath, self.name + '.syslog.log')
-        source.set('path', log_filename)
+        self.installlog = os.path.join(config.logpath, self.name + '.syslog.log')
+        source.set('path', self.installlog)
         serial.append(source)
         target = ElementTree.Element('target')
         target.set('port', '0')
@@ -426,13 +427,22 @@
         vm.create()
         self.logger.info('Installing system on VM (may take over an hour)')
         self.logger.info('You can watch the progress with virt-viewer')
-        log_filename = os.path.join(config.logpath, self.name + '.syslog.log')
-        self.logger.info('Logs will be written to ' + log_filename)
+        self.logger.info('Logs will be written to ' + self.installlog)
+        self.logger.debug('Log file size is {}'
+                          .format(os.path.getsize(self.installlog)))
 
         while vm.isActive() is not 0:
+            self.logger.debug('Log file size is {}'
+                              .format(os.path.getsize(self.installlog)))
+
             pass
 
+        self.logger.debug('Log file size is {}'
+                          .format(os.path.getsize(self.installlog)))
         vm.undefine()
+        self.logger.debug('Log file size is {}'
+                          .format(os.path.getsize(self.installlog)))
+
         self.logger.info('Installation complete')
 
     def _finalxml(self, tmpdir=None, xml=None):