Merge lp:~nuclearbob/utah/boostpeed-no-envinject into lp:utah/utah-bootspeed

Proposed by Max Brustkern
Status: Merged
Merged at revision: 216
Proposed branch: lp:~nuclearbob/utah/boostpeed-no-envinject
Merge into: lp:utah/utah-bootspeed
Diff against target: 93 lines (+16/-26)
5 files modified
bootspeed/jenkins/templates/base.xml.jinja (+3/-18)
bootspeed/jenkins/templates/bootspeed.xml.jinja (+0/-1)
bootspeed/jenkins/templates/download.xml.jinja (+4/-3)
bootspeed/jenkins/templates/parametrized.xml.jinja (+2/-4)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~nuclearbob/utah/boostpeed-no-envinject
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
Review via email: mp+165653@code.launchpad.net

Description of the change

This is a new proposal since I goobed up the old one a bit. This attempts to simplify the diff by recreating some old environment variables in the download template per Andy's suggestion.

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bootspeed/jenkins/templates/base.xml.jinja'
2--- bootspeed/jenkins/templates/base.xml.jinja 2013-05-03 15:49:23 +0000
3+++ bootspeed/jenkins/templates/base.xml.jinja 2013-05-24 15:51:28 +0000
4@@ -37,6 +37,9 @@
5 </hudson.tasks.Shell>
6 <hudson.tasks.Shell>
7 <command>
8+{% block image %}
9+IMAGE=/var/cache/utah/iso/{{series}}-{{installtype}}-{{arch}}.iso
10+{% endblock %}
11 {% block command %}{% endblock %}
12 </command>
13 </hudson.tasks.Shell>
14@@ -70,22 +73,4 @@
15 </hudson.plugins.build__publisher.BuildPublisher>
16 {% endif %}
17 </publishers>
18- <buildWrappers>
19- <EnvInjectBuildWrapper>
20- <info>
21- <propertiesContent>
22-TYPE={{installtype}}
23-ARCH={{arch}}
24-{% if is_parametrized is not defined %}
25-SERIES={{series}}
26-ISONAME=$SERIES-$TYPE-$ARCH.iso
27-ISODIR=/var/cache/utah/iso
28-IMAGE=$ISODIR/$ISONAME
29-{% endif %}
30-{% block properties %}{% endblock %}
31- </propertiesContent>
32- <loadFilesFromMaster>false</loadFilesFromMaster>
33- </info>
34- </EnvInjectBuildWrapper>
35- </buildWrappers>
36 </project>
37
38=== modified file 'bootspeed/jenkins/templates/bootspeed.xml.jinja'
39--- bootspeed/jenkins/templates/bootspeed.xml.jinja 2013-02-22 16:35:23 +0000
40+++ bootspeed/jenkins/templates/bootspeed.xml.jinja 2013-05-24 15:51:28 +0000
41@@ -39,4 +39,3 @@
42
43 exit $RETCODE
44 {% endblock %}
45-
46
47=== modified file 'bootspeed/jenkins/templates/download.xml.jinja'
48--- bootspeed/jenkins/templates/download.xml.jinja 2013-01-09 21:56:29 +0000
49+++ bootspeed/jenkins/templates/download.xml.jinja 2013-05-24 15:51:28 +0000
50@@ -16,7 +16,8 @@
51 rm $TMPISO
52 {% endblock %}
53
54-{% block properties %}
55-ISOURL={{url}}$SERIES/$ISONAME
56-TMPISO=/tmp/$ISONAME
57+{% block image %}
58+{{ super() }}
59+ISOURL={{url}}{{series}}/{{series}}-{{installtype}}-{{arch}}.iso
60+TMPISO=/tmp/{{series}}-{{installtype}}-{{arch}}.iso
61 {% endblock %}
62
63=== modified file 'bootspeed/jenkins/templates/parametrized.xml.jinja'
64--- bootspeed/jenkins/templates/parametrized.xml.jinja 2013-01-09 21:56:29 +0000
65+++ bootspeed/jenkins/templates/parametrized.xml.jinja 2013-05-24 15:51:28 +0000
66@@ -39,10 +39,8 @@
67 {% endif %}
68 {% endblock %}
69
70-{% block properties %}
71+{% block image %}
72 {% if backfilldir is defined %}
73-IMAGE={{backfilldir}}/$BUILDNUMBER/*-$TYPE-$ARCH.iso
74+IMAGE={{backfilldir}}/$BUILDNUMBER/*-{{installtype}}-{{arch}}.iso
75 {% endif %}
76-{{ super() }}
77 {% endblock %}
78-
79
80=== modified file 'debian/changelog'
81--- debian/changelog 2012-08-20 20:42:19 +0000
82+++ debian/changelog 2013-05-24 15:51:28 +0000
83@@ -1,3 +1,10 @@
84+utah-bootspeed (0.2ubuntu1) UNRELEASED; urgency=low
85+
86+ * Changed jobs to pull variables from templates instead of using
87+ EnvInject for environment variables
88+
89+ -- Max Brustkern <max@canonical.com> Fri, 24 May 2013 11:07:43 -0400
90+
91 utah-bootspeed (0.1ubuntu3) precise; urgency=low
92
93 * Updated scripts to work with utah as modified for sphinx

Subscribers

People subscribed via source and target branches

to all changes: