Merge lp:~nuclearbob/uci-engine/virtualenv-dependencies into lp:uci-engine

Proposed by Max Brustkern
Status: Merged
Approved by: Francis Ginther
Approved revision: 830
Merged at revision: 835
Proposed branch: lp:~nuclearbob/uci-engine/virtualenv-dependencies
Merge into: lp:uci-engine
Diff against target: 12 lines (+1/-1)
1 file modified
README (+1/-1)
To merge this branch: bzr merge lp:~nuclearbob/uci-engine/virtualenv-dependencies
Reviewer Review Type Date Requested Status
Francis Ginther Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+237322@code.launchpad.net

Commit message

Updated virtualenv dependencies

Description of the change

This branch updates the dependencies for building the virtualenv in the README

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:829
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1540/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1540/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Yep, looks right with the addition of libffi-dev. Tarmac is actually configured to install "build-essential python-pip python-virtualenv python-setuptools python-dev make python-apt-dev libffi-dev libssl-dev autopkgtest haveged devscripts", but I know not all of these are needed for building the virtualenv.

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

Correction. Please add 'python-dev' to this list. I did some additional testing and found that to be required for creating the venv.

review: Needs Fixing
830. By Max Brustkern

Added python-dev

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Should be updated now.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:830
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1558/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1558/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Thanks Max.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2014-09-18 12:58:13 +0000
3+++ README 2014-10-08 12:17:36 +0000
4@@ -16,7 +16,7 @@
5 ~~~~~~~~~~~~~
6 ::
7 # setup the ticket system project
8- sudo apt-get install virtualenv libssl-dev libapt-pkg-dev
9+ sudo apt-get install python-virtualenv libssl-dev libapt-pkg-dev libffi-dev python-dev
10 ./testing/venv.py /tmp/venv
11 . /tmp/venv/bin/activate
12 ./ci-utils/setup.py develop

Subscribers

People subscribed via source and target branches