Merge lp:~nuclearbob/ubuntu-test-cases/bootspeed-media-info into lp:ubuntu-test-cases/bootspeed

Proposed by Max Brustkern
Status: Merged
Merged at revision: 80
Proposed branch: lp:~nuclearbob/ubuntu-test-cases/bootspeed-media-info
Merge into: lp:ubuntu-test-cases/bootspeed
Diff against target: 12 lines (+2/-0)
1 file modified
jenkins/templates/bootspeed.xml.jinja (+2/-0)
To merge this branch: bzr merge lp:~nuclearbob/ubuntu-test-cases/bootspeed-media-info
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+205615@code.launchpad.net

Description of the change

This change adds media info output to the new job configuration.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

I'm assuming you've tested this, looks fine to me though. Maybe we should use this other places? Is it more reliable?

review: Approve
Revision history for this message
Max Brustkern (nuclearbob) wrote :

I've tested the python one-liner, but I haven't actually changed the jobs since I don't have a great way to do that and test it locally. The thing I like about using the utah ISO class for it is that it supports mini images with the same syntax. It's reliable for whatever images utah supports, so if maintenance is primarily for touch images, it could eventually get out of sync with desktop stuff, but I'm not sure it will bitrot any faster than any other method we'd use.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

I pushed this but I haven't updated the jobs yet. I'm going to work on them a bit today and propose something with more changes (at the very least, a jobtimeout) when I've run down a few more of the issues with the new setup.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jenkins/templates/bootspeed.xml.jinja'
2--- jenkins/templates/bootspeed.xml.jinja 2014-01-10 22:06:34 +0000
3+++ jenkins/templates/bootspeed.xml.jinja 2014-02-10 16:05:16 +0000
4@@ -8,6 +8,8 @@
5 {% block command %}
6 set +e
7
8+python -c "from utah.iso import ISO;print('Media Info: {}'.format(ISO(image='$IMAGE').media_info))"
9+
10 # Create custom configuration file and separate per-job log files
11 export UTAH_CONFIG_FILE=${WORKSPACE}/utah.cfg
12 cat <<EOF > ${UTAH_CONFIG_FILE}

Subscribers

People subscribed via source and target branches