Merge lp:~ntrrgc/inkscape/inkscape into lp:~inkscape.dev/inkscape/trunk

Proposed by Alicia Boya
Status: Merged
Approved by: Mc
Approved revision: no longer in the source branch.
Merged at revision: 14302
Proposed branch: lp:~ntrrgc/inkscape/inkscape
Merge into: lp:~inkscape.dev/inkscape/trunk
Diff against target: 101 lines (+33/-30)
3 files modified
CMakeLists.txt (+1/-1)
src/CMakeLists.txt (+31/-28)
src/svg/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~ntrrgc/inkscape/inkscape
Reviewer Review Type Date Requested Status
Mc Approve
Review via email: mp+267893@code.launchpad.net

Description of the change

I have modified the CMake files in order to build inkview too.

Object files are compiled only once and then linked by both inkscape and inkview.

To post a comment you must log in.
lp:~ntrrgc/inkscape/inkscape updated
14294. By jazzynico

Translations. New script for PO files statistics.

14295. By jazzynico

Tutorials. Tutorials check script update.

14296. By jazzynico

Translations. Fixing bad tutorials links in UI translations.

14297. By jazzynico

Tutorials. Adding new Greek, Chineese (TW) and French translations for Tracing pixel art.
Tutorials. Fixing more tutorial references in the UI translation files.
Tutorials. Adding missing Russian interpolate and Dutch Tracing pixel art tutorials in Makefile.am.

14298. By Krzysztof Kosinski

Fix bug in Maithili .po file.

One of the tutorial strings had a duplicate msgid line instead
of a msgid-msgstr pair, thereby causing a message compilation error.

14299. By Krzysztof Kosinski

2Geom: update to r2422.

Fixes LP #1482806: crash on Pattern along Path with horizontal segments.
This was caused by empty SBasis objects. After the changes in 2Geom,
empty SBasis objects should no longer be created.

Revision history for this message
Mc (mc...) wrote :

Compiles successfully inkscape and inkview

review: Approve
lp:~ntrrgc/inkscape/inkscape updated
14300. By Jabiertxof <email address hidden>

Refactor of BSPline code attemping to fix the duplicate end node bug, not sure if fixed jet

14301. By Jabiertxof <email address hidden>

A bit more refactor of BSPline tool. Still the bug duplicating end node :(

14302. By Alicia Boya

add inkview to the cmake build

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2015-06-14 04:40:36 +0000
3+++ CMakeLists.txt 2015-08-13 13:19:02 +0000
4@@ -149,7 +149,7 @@
5 # TODO: man, locale
6
7 install(
8- PROGRAMS ${EXECUTABLE_OUTPUT_PATH}/inkscape
9+ PROGRAMS ${EXECUTABLE_OUTPUT_PATH}/inkscape ${EXECUTABLE_OUTPUT_PATH}/inkview
10 DESTINATION ${CMAKE_INSTALL_PREFIX}/bin
11 )
12
13
14=== modified file 'src/CMakeLists.txt'
15--- src/CMakeLists.txt 2015-06-08 19:01:23 +0000
16+++ src/CMakeLists.txt 2015-08-13 13:19:02 +0000
17@@ -509,8 +509,14 @@
18 #add_inkscape_lib(sp_LIB "${sp_SRC}")
19 #add_inkscape_lib(inkscape_LIB "${inkscape_SRC}")
20
21-# make executable for INKSCAPE
22-add_executable(inkscape ${main_SRC} ${inkscape_SRC} ${sp_SRC})
23+# Build everything except main and inkview.c in a CMake "object" library.
24+# An object library is just a bunch of .o files. Linking them with main.c or inkview.c
25+# we get the inkscape and inkview executables respectively.
26+add_library(inkscape_base OBJECT ${inkscape_SRC} ${sp_SRC})
27+
28+# make executables for inkscape and inkview
29+add_executable(inkscape ${main_SRC} $<TARGET_OBJECTS:inkscape_base>)
30+add_executable(inkview inkview.cpp $<TARGET_OBJECTS:inkscape_base>)
31
32 if(UNIX)
33 # message after building.
34@@ -523,31 +529,28 @@
35
36 add_dependencies(inkscape inkscape_version)
37
38-target_link_libraries(inkscape
39- # order from automake
40- #sp_LIB
41- #nrtype_LIB
42-
43- #inkscape_LIB
44- #sp_LIB # annoying, we need both!
45- nrtype_LIB # annoying, we need both!
46-
47- croco_LIB
48- avoid_LIB
49- gdl_LIB
50- cola_LIB
51- vpsc_LIB
52- livarot_LIB
53- uemf_LIB
54- 2geom_LIB
55- depixelize_LIB
56- util_LIB
57- gc_LIB
58-
59- ${INKSCAPE_LIBS}
60+set(INKSCAPE_TARGET_LIBS
61+ # order from automake
62+ #sp_LIB
63+ #nrtype_LIB
64+
65+ #inkscape_LIB
66+ #sp_LIB # annoying, we need both!
67+ nrtype_LIB # annoying, we need both!
68+
69+ croco_LIB
70+ avoid_LIB
71+ gdl_LIB
72+ cola_LIB
73+ vpsc_LIB
74+ livarot_LIB
75+ uemf_LIB
76+ 2geom_LIB
77+ depixelize_LIB
78+ util_LIB
79+ gc_LIB
80+ ${INKSCAPE_LIBS}
81 )
82
83-# TODO
84-# make executable for INKVIEW
85-#add_executable(inkview inkview.cpp)
86-# ...
87+target_link_libraries(inkscape ${INKSCAPE_TARGET_LIBS})
88+target_link_libraries(inkview ${INKSCAPE_TARGET_LIBS})
89
90=== modified file 'src/svg/CMakeLists.txt'
91--- src/svg/CMakeLists.txt 2014-10-14 11:01:49 +0000
92+++ src/svg/CMakeLists.txt 2015-08-13 13:19:02 +0000
93@@ -2,7 +2,7 @@
94 set(svg_SRC
95 css-ostringstream.cpp
96 path-string.cpp
97- sp-svg.def
98+ #sp-svg.def
99 stringstream.cpp
100 strip-trailing-zeros.cpp
101 svg-affine.cpp