~nteodosio/software-properties:valid-magic-wait-event

Last commit made on 2023-03-03
Get this branch:
git clone -b valid-magic-wait-event https://git.launchpad.net/~nteodosio/software-properties
Only Nathan Teodosio can upload to this branch. If you are Nathan Teodosio please log in for upload directions.

Branch merges

Branch information

Name:
valid-magic-wait-event
Repository:
lp:~nteodosio/software-properties

Recent commits

7298048... by Nathan Teodosio

Make PIN validation wait to update UI until magic radio is selected.

https://launchpad.net/bugs/2006940

970dbfe... by Nathan Teodosio

Don't initiate magic request without internet.

a4dffce... by Nathan Teodosio

Improve exception print statements.

91ecb16... by Nathan Teodosio

Restart dead poll if connection came back.

c175dad... by Nathan Teodosio

Lock UI (except for cancel button) if no internet.

e0b8ce3... by Nathan Teodosio

Alert if network goes down

684756f... by Nathan Teodosio

Polling: Catch any exception to wait()

Uncaught exceptions to wait will trigger error reports even though
it's only the polling thread that dies:
https://launchpad.net/bugs/2003996

They are caused by connectivity issues.

This is temporary until a UX plan has been devised to warn the user
about the connectivity issue.

ccdd0c7... by Nathan Teodosio

Initialize pin as empty string

start_magic_attach is the only function that assigns a value to pin.
If it can't retrieve it from the server, then it is uninitialized and
selecting the pin radio button causes an error as update_state tries
to use it (LP: #2004245).

de08d1e... by Sebastien Bacher

releasing package software-properties version 0.99.31

7e77d82... by Nathan Teodosio

Pass True or False if boolean argument is expected.

String->True and None->False is not reliable.