Merge ~nteodosio/software-properties:xenial-ua into software-properties:ubuntu/xenial

Proposed by Nathan Teodosio
Status: Merged
Approved by: Sebastien Bacher
Approved revision: f0d3c27c668c065ca1c5c92b100887462e2e4c27
Merge reported by: Sebastien Bacher
Merged at revision: f0d3c27c668c065ca1c5c92b100887462e2e4c27
Proposed branch: ~nteodosio/software-properties:xenial-ua
Merge into: software-properties:ubuntu/xenial
Diff against target: 25 lines (+1/-2)
2 files modified
softwareproperties/gtk/DialogUaAttach.py (+1/-1)
softwareproperties/gtk/SoftwarePropertiesGtk.py (+0/-1)
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+454603@code.launchpad.net

Description of the change

From https://autopkgtest.ubuntu.com/results/autopkgtest-xenial/xenial/amd64/s/software-properties/20231025_143307_0491f@/log.gz:

  WARNING: syntax errors in softwareproperties/gtk/DialogUaAttach.py: invalid syntax (DialogUaAttach.py, line 154)

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/softwareproperties/gtk/DialogUaAttach.py b/softwareproperties/gtk/DialogUaAttach.py
2index 6fcfc92..38b9044 100644
3--- a/softwareproperties/gtk/DialogUaAttach.py
4+++ b/softwareproperties/gtk/DialogUaAttach.py
5@@ -151,7 +151,7 @@ class DialogUaAttach:
6 except MagicAttachTokenError:
7 GLib.idle_add(self.update_state, 'expired')
8 except Exception as e:
9- print("Error getting the Ubuntu Pro token: ", e, flush = True)
10+ print("Error getting the Ubuntu Pro token: ", e)
11 finally:
12 self.poll = None
13
14diff --git a/softwareproperties/gtk/SoftwarePropertiesGtk.py b/softwareproperties/gtk/SoftwarePropertiesGtk.py
15index 6257e93..5987e97 100644
16--- a/softwareproperties/gtk/SoftwarePropertiesGtk.py
17+++ b/softwareproperties/gtk/SoftwarePropertiesGtk.py
18@@ -37,7 +37,6 @@ from aptdaemon.errors import NotAuthorizedError, TransactionFailed
19 import logging
20 import threading
21 import sys
22-import time
23
24 import gi
25 gi.require_version("Gdk", "3.0")

Subscribers

People subscribed via source and target branches