Merge ~nteodosio/software-properties:threading into software-properties:ubuntu/master
Proposed by
Nathan Teodosio
Status: | Merged |
---|---|
Merge reported by: | Nathan Teodosio |
Merged at revision: | 4657ca5da215eb24805ac5b71c7962365a0757ce |
Proposed branch: | ~nteodosio/software-properties:threading |
Merge into: | software-properties:ubuntu/master |
Diff against target: |
44 lines (+4/-4) 2 files modified
softwareproperties/SoftwareProperties.py (+2/-1) softwareproperties/gtk/DialogUaAttach.py (+2/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastien Bacher | Pending | ||
Review via email: mp+434815@code.launchpad.net |
Description of the change
GLib.Thread is not available in Bionic and Focal: https:/
Use Python threading module.
Also need to let daemonic threads go lest software-properties becomes uncloseable after invoking the UA attach dialog without subsequent verification of the PIN in the magic attach flow.
That, in my reading, is backed up by the definition of daemonic thread[1]:
> A thread can be flagged as a “daemon thread”. The significance of this flag is that the entire Python program exits when only daemon threads are left.
To post a comment you must log in.
For the record, this was merged in Bionic only: https:/ /git.launchpad. net/software- properties/ commit/ ?id=5f7360ce3aa f89314688502994 6b3bc8a8b2c9ed