Merge ~nteodosio/chromium-browser:pipewire into ~chromium-team/chromium-browser/+git/snap-from-source:beta

Proposed by Nathan Teodosio
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 85504fc095097e1bc7cdeda3433f1864c5249304
Merge reported by: Nathan Teodosio
Merged at revision: 85504fc095097e1bc7cdeda3433f1864c5249304
Proposed branch: ~nteodosio/chromium-browser:pipewire
Merge into: ~chromium-team/chromium-browser/+git/snap-from-source:beta
Diff against target: 27 lines (+3/-12)
1 file modified
snapcraft.yaml (+3/-12)
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+443465@code.launchpad.net

Commit message

Use Pipewire from the archives instead of building it from source.

Description of the change

Passes the https://wiki.ubuntu.com/Process/Merges/TestPlans/chromium, from my tests indistinguishable from the current snap in beta.

Ticket: UDENG-383.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Yes, the 22.04 pipewire is new enough for that to work, that's not the case for the core20 though so not something to backport to stable yet

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 4d5a012..dcfd082 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -378,19 +378,10 @@ parts:
6 stage:
7 - usr/lib/*/dri/*_video.so
8
9- # PipeWire
10 pipewire:
11- source: https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/0.3.32/pipewire-0.3.32.tar.gz
12- plugin: meson
13- meson-parameters:
14- - --prefix=/usr
15- - --buildtype=release
16- - --strip
17- - -Dalsa=disabled
18- - -Dpipewire-alsa=disabled
19- - -Djack=disabled
20- - -Dpipewire-jack=disabled
21- - -Dsession-managers=[]
22+ plugin: nil
23+ build-packages: [libpipewire-0.3-dev]
24+ stage-packages: [pipewire]
25 prime:
26 - usr/lib/*/pipewire-*
27 - usr/lib/*/spa-*

Subscribers

People subscribed via source and target branches

to status/vote changes: