Merge ~nteodosio/chromium-browser:dev into ~chromium-team/chromium-browser/+git/snap-from-source:dev

Proposed by Nathan Teodosio
Status: Merged
Merged at revision: 54aaad9cf864a3f396158cf91e4c76c3049faf81
Proposed branch: ~nteodosio/chromium-browser:dev
Merge into: ~chromium-team/chromium-browser/+git/snap-from-source:dev
Diff against target: 38 lines (+21/-0)
2 files modified
build/chromium-patches/build-script-limit-compile-jobs.patch (+20/-0)
build/chromium-patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
Review via email: mp+424110@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

LGTM, thanks Nathan!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/build/chromium-patches/build-script-limit-compile-jobs.patch b/build/chromium-patches/build-script-limit-compile-jobs.patch
2new file mode 100644
3index 0000000..59fd6c2
4--- /dev/null
5+++ b/build/chromium-patches/build-script-limit-compile-jobs.patch
6@@ -0,0 +1,20 @@
7+Description: Compile the bootstrap compiler with a limited (empirically
8+determined) number of jobs on Arm64. Ninja defaults to NCPU jobs (NCPU being
9+the number of CPUs the system has). This was observed to exhaust the memory
10+of Arm64 Launchpad builders, triggering the OOM killer.
11+Author: Nathan Pratta Teodosio <nathan.teodosio@canonical.com>
12+Forwarded: not-needed
13+
14+--- a/tools/clang/scripts/build.py
15++++ b/tools/clang/scripts/build.py
16+@@ -746,6 +746,10 @@
17+ # Ignore args.disable_asserts for the bootstrap compiler.
18+ '-DLLVM_ENABLE_ASSERTIONS=ON',
19+ ]
20++ if sys.platform.startswith('linux') and platform.machine() == 'aarch64':
21++ bootstrap_args.extend([
22++ '-DLLVM_PARALLEL_COMPILE_JOBS=2',
23++ ])
24+ if sys.platform == 'darwin':
25+ # On macOS, the bootstrap toolchain needs to have compiler-rt because
26+ # dsymutil's link needs libclang_rt.osx.a. Only the x86_64 osx
27diff --git a/build/chromium-patches/series b/build/chromium-patches/series
28index 6bff65c..9a7fd85 100644
29--- a/build/chromium-patches/series
30+++ b/build/chromium-patches/series
31@@ -12,6 +12,7 @@ build-script-predownload-pgo-training-source.patch
32 build-script-fix-bootstrap-targets.patch
33 build-script-unset-default-target-triple.patch
34 build-script-revert-build-with-stable-clang.patch
35+build-script-limit-compile-jobs.patch
36 chromedriver-snap-compatibility.patch
37 node-update-binaries-arch-specific.patch
38 libaom-armhf-build-cpudetect.patch

Subscribers

People subscribed via source and target branches

to status/vote changes: