Ubuntu Weather App

Merge lp:~nskaggs/ubuntu-weather-app/fix-db-path into lp:ubuntu-weather-app/obsolete.trunk

  1. fix-db-path
  2. Merge into trunk
Proposed by Nicholas Skaggs
Status: Rejected
Rejected by: Nicholas Skaggs
Proposed branch: lp:~nskaggs/ubuntu-weather-app/fix-db-path
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 11 lines (+1/-1)
1 file modified
tests/autopilot/ubuntu_weather_app/tests/__init__.py (+1/-1)
To merge this branch: bzr merge lp:~nskaggs/ubuntu-weather-app/fix-db-path
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Ubuntu Weather Developers Pending
Review via email: mp+189138@code.launchpad.net

Commit message

update the hardcoded db path so autopilot tests can continue to work

Description of the change

Fix https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1234544, update the hardcoded db path so autopilot tests can continue to work

To post a comment you must log in.
Revision history for this message
Martin Borho (martin-borho) wrote :

Thanks Nicholas,

but this already part of another merge proposal:

https://code.launchpad.net/~martin-borho/ubuntu-weather-app/LocationLookup/+merge/188781

Cheers
Martin

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:133
http://91.189.93.70:8080/job/ubuntu-weather-app-ci/58/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/635
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-precise-amd64-ci/56
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-quantal-amd64-ci/56
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-raring-amd64-ci/56
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-saucy-amd64-ci/56

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-ci/58/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Loïc Minier (lool) wrote :

Could you get the name from Qt/SDK instead of harcoding it? Otherwise we have to ensure the test and the updated SDK land at exactly the same time, and if the location changes again, it will break again.

Unmerged revisions

133. By Nicholas Skaggs

fix db path

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/ubuntu_weather_app/tests/__init__.py'
2--- tests/autopilot/ubuntu_weather_app/tests/__init__.py 2013-09-29 14:26:37 +0000
3+++ tests/autopilot/ubuntu_weather_app/tests/__init__.py 2013-10-03 17:28:34 +0000
4@@ -107,7 +107,7 @@
5 """
6
7 def find_db(self):
8- dbs_path = os.path.expanduser("~/.local/share/Qt Project/QtQmlViewer/QML/OfflineStorage/Databases/")
9+ dbs_path = os.path.expanduser("~/.local/share/ubuntu-weather-app/Databases")
10 if not os.path.exists(dbs_path):
11 return None
12

Subscribers

People subscribed via source and target branches