Merge lp:~nskaggs/ubuntu-weather-app/1362234 into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Nicholas Skaggs
Status: Merged
Approved by: Martin Borho
Approved revision: 347
Merged at revision: 356
Proposed branch: lp:~nskaggs/ubuntu-weather-app/1362234
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 12 lines (+1/-1)
1 file modified
ubuntu-weather-app.qml (+1/-1)
To merge this branch: bzr merge lp:~nskaggs/ubuntu-weather-app/1362234
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Martin Borho Approve
Review via email: mp+232443@code.launchpad.net

Commit message

Change background text color to white

Description of the change

Change background text color to white

To post a comment you must log in.
Revision history for this message
Martin Borho (martin-borho) wrote :

There was a "#55FFFFFF" and I've wondered what its good for and made a "#55FFFF" out of it. Probably the wrong choice.. ;)

Thanks a lot!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Hmm, The C compiler "/usr/bin/x86_64-linux-gnu-gcc" is not able to compile a
  simple test program.

Perhaps something with jenkins, I'll have francis have a look.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

So jenkins errors have been resolved, but now the tests are failing. I kicked off another build so we can get video of the failures (hopefully). If so, it would indicate trunk is failing in jenkins, as this change is insignificant.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Martin Borho (martin-borho) wrote :

The one test, that failed in the last build, should be fixed by the pagestack MP.

Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :
Revision history for this message
Martin Borho (martin-borho) wrote :

But pagestack fails different.

The fix for the test which fails here should be fixed in pagestack MP, but I have no clue why pagestack MP fails.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-weather-app.qml'
2--- ubuntu-weather-app.qml 2014-08-13 19:37:28 +0000
3+++ ubuntu-weather-app.qml 2014-08-27 16:22:24 +0000
4@@ -227,7 +227,7 @@
5 //storage.clearSetting('units');
6
7 //Theme.palette.selected.backgroundText = "#000000";
8- Theme.palette.normal.backgroundText = "#55FFFF";
9+ Theme.palette.normal.backgroundText = "#FFFFFF";
10 Theme.palette.normal.background = "#ECECEC"
11
12 storage.getSettings(function(storedSettings) {

Subscribers

People subscribed via source and target branches