Merge lp:~nskaggs/ubuntu-ui-toolkit/fix-aphelper-emulator-warning into lp:ubuntu-ui-toolkit

[Nicholas Skaggs]

remove emulators from toolkit ap helper import (deprecated)

Fix the warning for the emulators module by removing it from the base import.

"The ubuntuuitoolkit.emulators module is deprecated. Import the autopilot helpers from the top-level ubuntuuitoolkit module."

The warning will now only appear if you use the module directly.

[lp:~nskaggs/ubuntu-ui-toolkit/fix-aphelper-emulator-warning]

1055. By Nicholas Skaggs on 2014-07-14

fix property changes

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1055
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/2110/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1972
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1653
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-utopic-amd64-ci/56
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-utopic-armhf-ci/56
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-utopic-armhf-ci/56/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2213
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3087
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3087/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9817
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1385
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1856
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1856/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-toolkit-ci/2110/rebuild

review: Approve (continuous-integration)

[Leo Arias (elopio)]

The warning is still being printed. Please notice that you need to remove the 'emulators' also from the __all__ list. And emulators is still being used on tests/__init__.py, which is imported by ubuntuuitoolkit. Probably we also need to remove tests from the ubuntuuitoolkit/__init__.py.

Sorry about the mess.

review: Needs Fixing (code review)

[Tim Peeters (tpeeters)]

Please submit new MRs for merging into lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging. It needs to go there first before we land it in trunk.

review: Needs Resubmitting

[lp:~nskaggs/ubuntu-ui-toolkit/fix-aphelper-emulator-warning]

1056. By Nicholas Skaggs on 2014-07-16

convert references of emulator to custom proxy object

1057. By Nicholas Skaggs on 2014-07-16

rebase trunk

1058. By Nicholas Skaggs on 2014-07-16

rebase staging

1059. By Nicholas Skaggs on 2014-07-16

flake8 happiness

1060. By Nicholas Skaggs on 2014-07-16

fix toolkitemulator exception

1061. By Nicholas Skaggs on 2014-07-16

remove references to ToolkitCustomProxyObjectException

1062. By Nicholas Skaggs on 2014-07-16

add test to assure warning is not shown improperly

1063. By Nicholas Skaggs on 2014-07-24

rebase to staging

1064. By Nicholas Skaggs on 2014-07-28

migrate testcase to test_import.py

1065. By Nicholas Skaggs on 2014-08-06

add class to avoid pyflakes error

1066. By Nicholas Skaggs on 2014-08-07

fix blankclass

1067. By Nicholas Skaggs on 2014-08-07

remove test_import_toolkit_must_not_log_warning

Unmerged revisions

=== modified file 'tests/autopilot/ubuntuuitoolkit/__init__.py'
--- tests/autopilot/ubuntuuitoolkit/__init__.py	2014-06-30 10:49:51 +0000
+++ tests/autopilot/ubuntuuitoolkit/__init__.py	2014-07-14 17:35:21 +0000
@@ -48,7 +48,6 @@
 
 from ubuntuuitoolkit import (
     base,
-    emulators,
     environment,
     fixture_setup,
     tests,