Merge lp:~nskaggs/ubuntu-ui-toolkit/aphelperdocs-staging into lp:ubuntu-ui-toolkit/staging
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Tim Peeters on 2015-02-03 | ||||||||
| Approved revision: | 1386 | ||||||||
| Merged at revision: | 1396 | ||||||||
| Proposed branch: | lp:~nskaggs/ubuntu-ui-toolkit/aphelperdocs-staging | ||||||||
| Merge into: | lp:ubuntu-ui-toolkit/staging | ||||||||
| Diff against target: |
877 lines (+805/-0) 10 files modified
README (+16/-0) debian/control (+1/-0) debian/rules (+3/-0) debian/ubuntu-ui-toolkit-autopilot.docs (+2/-0) documentation/autopilot-helpers/Makefile (+177/-0) documentation/autopilot-helpers/_static/nature.css (+211/-0) documentation/autopilot-helpers/_templates/layout.html (+28/-0) documentation/autopilot-helpers/conf.py (+340/-0) documentation/autopilot-helpers/index.rst (+17/-0) documentation/autopilot-helpers/ubuntuuitoolkit.rst (+10/-0) |
||||||||
| To merge this branch: | bzr merge lp:~nskaggs/ubuntu-ui-toolkit/aphelperdocs-staging | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve on 2015-02-03 | |
| Tim Peeters | 2015-01-14 | Approve on 2015-02-03 | |
| Zoltan Balogh | packaging | 2015-01-29 | Pending |
| Leo Arias | autopilot doc coverage | 2015-01-26 | Pending |
|
Review via email:
|
|||
This proposal supersedes a proposal from 2015-01-13.
Commit Message
Re-add autopilot helper documentation and update
Description of the Change
Re-add autopilot helper documentation and update. I placed the resulting sphinx documentation in ubuntu-
| Nicholas Skaggs (nskaggs) wrote : | # |
bah; sphinx isn't a build depends. Perhaps I can't do things this way since we are building ubuntu-ui-toolkit?
- 1381. By Nicholas Skaggs on 2015-01-14
-
move sphinx to build-depends
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1381
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| Nicholas Skaggs (nskaggs) wrote : | # |
sphinx-build -b singlehtml documentation/
make[1]: sphinx-build: Command not found.
it seems not.
- 1382. By Nicholas Skaggs on 2015-01-23
-
add makefile
- 1383. By Nicholas Skaggs on 2015-01-23
-
move build depends back
- 1384. By Nicholas Skaggs on 2015-01-23
-
rebase to trunk
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1384
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
- 1385. By Nicholas Skaggs on 2015-01-26
-
pep8
- 1386. By Nicholas Skaggs on 2015-01-26
-
fix for pyflakes
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1385
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1385
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Nicholas Skaggs (nskaggs) wrote : | # |
This is ready now for proper review. No packaging issues, mainline exceptions or other should remain.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1386
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1386
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Tim Peeters (tpeeters) wrote : | # |
Is Sphinx the common thing we use for all autopilot docs?
| Tim Peeters (tpeeters) wrote : | # |
Looks good, thanks!
I would like to get a second opinion from Zoltan about the packaging. Perhaps we should include a build target for for the toolkit that generates these docs, and maybe we need to package them as well?
| Nicholas Skaggs (nskaggs) wrote : | # |
Yes, having another package is an option. Something like ubuntu-
If you do wish to have another package specifically for this I worry folks won't install it and will miss the documentation.
| Nicholas Skaggs (nskaggs) wrote : | # |
And yes, sphinx is common for all python projects in general.
| Nicholas Skaggs (nskaggs) wrote : | # |
Per our conversation on IRC Zoltan, I filed a bug to capture your concerns.
https:/

FAILED: Continuous integration, rev:1380 jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- ci/1362/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 803/console jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-amd64- ci/89/console jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-armhf- ci/92/console jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-i386- ci/89/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 801/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- sdk-team- ubuntu- ui-toolkit- staging- ci/1362/ rebuild
http://