Merge lp:~nskaggs/ubuntu-terminal-app/add-jenkins-info into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Nicholas Skaggs
Status: Merged
Approved by: Stefano Verzegnassi
Approved revision: 183
Merged at revision: 183
Proposed branch: lp:~nskaggs/ubuntu-terminal-app/add-jenkins-info
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 36 lines (+32/-0)
1 file modified
README.mergeproposal.md (+32/-0)
To merge this branch: bzr merge lp:~nskaggs/ubuntu-terminal-app/add-jenkins-info
Reviewer Review Type Date Requested Status
Stefano Verzegnassi Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+288165@code.launchpad.net

Commit message

add jenkins info and mp readme

Description of the change

add jenkins info and mp readme

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'README.mergeproposal.md'
2--- README.mergeproposal.md 1970-01-01 00:00:00 +0000
3+++ README.mergeproposal.md 2016-03-04 20:09:15 +0000
4@@ -0,0 +1,32 @@
5+Prerequisites to approving a Merge Proposal (MP)
6+================================================
7+
8+Over time, it has been found that insufficient testing by reviewers sometimes leads to terminal trunk not buildable in Qtcreator due to manifest errors, or translation pot file not updated. As such, please follow the checklist below before top-approving a MP.
9+
10+Checklist
11+=========
12+
13+* Does the MP add/remove user visible strings? If Yes, has the pot file been
14+ updated?
15+
16+* Does the MP change the UI? If Yes, has it been approved by design?
17+
18+* Did you perform an exploratory manual test run of your code change and any
19+ related functionality?
20+
21+* If the MP fixes a bug or implements a feature, are there accompanying unit
22+ and autopilot tests?
23+
24+* Is the terminal trunk buildable and runnable using Qtcreator?
25+
26+* Was the debian changelog updated?
27+
28+* Was the copyright years updated if necessary?
29+
30+The above checklist is more of a guideline to help terminal trunk stay buildable,
31+stable and up to date.
32+
33+
34+Jenkins
35+=======
36+In addition to manual reviews, merge proposals are subject to being run in jenkins to ensure the application builds and any unit tests are successful. For more information on jenkins and how it works, see the [Core Apps Jenkins Wiki](https://wiki.ubuntu.com/Touch/CoreApps/Jenkins)

Subscribers

People subscribed via source and target branches