Code review comment for lp:~nskaggs/ubuntu-filemanager-app/fix-click-buddy-build

Revision history for this message
Carlos Jose Mazieri (carlos-mazieri) wrote :

Hi Nicholas, I saw this status " Work in Progress" just after approving it.

I am worried, right now there are building issues breaking File
Manager build/deploy, I would like someone to take a look on that. I
have two other changes to release and I cannot do it because this
problem.

By the way, do you mind removing this MP and propose it only when it is ready?

Thanks,
Carlos

On 4/21/14, Nicholas Skaggs <email address hidden> wrote:
> Hey Carlos, I don't want to merge this, as it's just for testing at the
> moment. These changes break qtcreator changes David put in on the last
> merge. We need to fix it so both things work. Thanks!
> --
> https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-click-buddy-build/+merge/216478
> You are reviewing the proposed merge of
> lp:~nskaggs/ubuntu-filemanager-app/fix-click-buddy-build into
> lp:ubuntu-filemanager-app.
>

« Back to merge proposal